Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared providers can't use explicit IDs #474

Open
thomastaylor312 opened this issue Oct 28, 2024 · 0 comments
Open

Shared providers can't use explicit IDs #474

thomastaylor312 opened this issue Oct 28, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@thomastaylor312
Copy link
Contributor

If I have a shared provider like the one in the example below that has an explicit ID, links do not work properly:

apiVersion: core.oam.dev/v1beta1
kind: Application
metadata:
  name: shared-provider
  annotations:
    description: "Shared provider instances"
    experimental.wasmcloud.dev/shared: "true"
spec:
  components:
    - name: custom-provider
      type: capability
      properties:
        image: custom-provider:0.0.0
        id: custom-provider
      traits:
        - type: spreadscaler
          properties:
            instances: 1

If you look at the published linkdefs, you'll get a different source ID than you should when using it in another manifest:

❯ wash link get


  Source ID                          Target                                 Interface(s)              Name
  shared_provider-custom_provider   01914a67-f1c6-70e6-9ddd-e4f4437ee407   wasi:http/incoming-handler   default

This should be just a fix that checks if a target manifest has an ID and to use that instead of generating it.

@thomastaylor312 thomastaylor312 added the bug Something isn't working label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant