Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Remove references to "model", replace with "manifest" or "application" #376

Open
brooksmtownsend opened this issue Aug 6, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation rust Pull requests that update Rust code stale

Comments

@brooksmtownsend
Copy link
Member

With the initial releases of wadm we had the notion of a "model", which has largely been replaced by "Application" in verbiage. Since developers don't ever interact with this idea of a "model", it can be confusing.

  • When referring to the actual YAML or the manifest itself, we should call it a Manifest.
  • When referring to the parsed + interpreted manifest, we should call it an Application

When in doubt, I think calling it an Application is good. I don't think we need to update the topics that wadm subscribes on quite yet, but any internal structures can be updated easily. Any public structs/enums/traits will need to be released with a breaking change, but that's no big deal.

@brooksmtownsend brooksmtownsend added documentation Improvements or additions to documentation rust Pull requests that update Rust code labels Aug 6, 2024
Copy link

stale bot commented Oct 5, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this has been closed too eagerly, please feel free to tag a maintainer so we can keep working on the issue. Thank you for contributing to wasmCloud!

@stale stale bot added the stale label Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation rust Pull requests that update Rust code stale
Projects
None yet
Development

No branches or pull requests

1 participant