fix: Update cache-control headers in Firebase transformer #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adjusted `Cache-Control` headers in `transformer-firebase.js`: - Added `max-age=31536000` to complement `s-maxage=31536000` and ensure consistent cache behavior across all levels. - Ensures better compatibility and optimized caching for static assets. - Removed commented-out unused code for cleaner and more maintainable configuration. - **Impact**: - Improves caching efficiency for assets by aligning cache-control directives. - Simplifies the Firebase hosting configuration for enhanced clarity.
|
Visit the preview URL for this PR (updated for commit f2fa5ac): https://bvarga-fe600--pr83-cache-fix-pcffcesb.web.app (expires Mon, 16 Dec 2024 06:53:01 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a3b1098a9eaf0750a134a339972f1df2a3969a8d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted
Cache-Controlheaders intransformer-firebase.js:max-age=31536000to complements-maxage=31536000and ensure consistent cache behavior across all levels.Removed commented-out unused code for cleaner and more maintainable configuration.
Impact: