Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decryption and decompression fixes and changes #6

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

CosmicDreamsOfCode
Copy link
Contributor

@CosmicDreamsOfCode CosmicDreamsOfCode commented Sep 2, 2024

  • Move shared decryption code into a new method to clean up a bit
  • Change decryption of assets to decrypt pages for compressed assets, this fixes assets with more than 1 compressed page failing to decrypt properly
  • Fix an issue where assets with 1 compressed page would fail to decompress because the output buffer wasn't correctly sized
  • Fix camel data is zlib compressed #5 by checking for the toc compression method when decompressing non-oodle assets
  • Fix localised assets and and part E slices still attempting to get data even if the sdfdata doesn't exist, return null for the former
  • Change exposed Assets enumerable to a list of file names instead, this is more compatible with the methods we have in GameManager for getting asset data, also added a a method to get this list through the GameManager, as it was previously inaccessible

Copy link
Owner

@wannkunstbeikor wannkunstbeikor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some small changes and one question, but looks good

Galanthus/SdfToc.cs Outdated Show resolved Hide resolved
Galanthus/SdfToc.cs Outdated Show resolved Hide resolved
Galanthus/SdfToc.cs Outdated Show resolved Hide resolved
Galanthus/SdfToc.cs Outdated Show resolved Hide resolved
Galanthus/SdfToc.cs Outdated Show resolved Hide resolved
Galanthus/SdfToc.cs Outdated Show resolved Hide resolved
Galanthus/SdfToc.cs Outdated Show resolved Hide resolved
Galanthus/SdfToc.cs Outdated Show resolved Hide resolved
@wannkunstbeikor wannkunstbeikor merged commit bc2ce4f into wannkunstbeikor:master Sep 2, 2024
1 check passed
@CosmicDreamsOfCode CosmicDreamsOfCode deleted the fixes branch September 2, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

camel data is zlib compressed
2 participants