Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion to new Mailextension or Webextensions Experiments API #89

Open
riedel opened this issue Feb 3, 2020 · 4 comments
Open

Conversion to new Mailextension or Webextensions Experiments API #89

riedel opened this issue Feb 3, 2020 · 4 comments

Comments

@riedel
Copy link

riedel commented Feb 3, 2020

Is this even feasible??

Addressing TB78 Mailextension would mean a rewrite and I am pretty sure that currently some stuff is not yet working due to the current API. Can someone confirm that eg. date filtering would not work easily.

I thing the quickfilter function comes would be the easiest to go for but only the query function exposes enought expressiveness but does not interact with the MailTabs i think.

Or would WebExtension Experiments be the way to go?

I have actually never seen a custom search field in a webextension, but I might be ignorant and there is an API.

Any thoughts on the migration?

@riedel
Copy link
Author

riedel commented Feb 12, 2020

The Mailextension API seems pretty unusable in its current state. Filed a bug here: https://bugzilla.mozilla.org/show_bug.cgi?id=1614916 .

@EaterOA
Copy link

EaterOA commented Aug 3, 2020

Hi @riedel, do you know if anything changed with the Thunderbird 78 API that might make porting expression-search to Mailextension or Webextensions Experiments easier? I'm not experienced with Thunderbird add-on development, but I do know some Javascript and I depend a lot on this add-on, so I want to explore how feasible it is to port it.

@EaterOA
Copy link

EaterOA commented Aug 3, 2020

FWIW the TB78 didn't seem much different to me from TB68, so I looked into Experiments a bit. Working backwards from mailTabs.setQuickFilter, I landed on MessageTextFilter. The comments seem to suggest that different filterers (e.g. TagFacetingFilter) can be implemented by extensions... although this is already deep in the realm of Experiments and not regular Mailextensions.

EDIT: I hadn't realized this seems to be exactly what expression-search is already doing for <=TB68. It's just no longer accessible from TB78 onwards via Mailextension. I suspect it may be possible to basically declare the ExpressionSearchFilter.js as an Experiments API, and regain the same functionality without extensive rewrite.

@malix0
Copy link

malix0 commented Aug 8, 2020

The best solution will be a native TB support, please add your vote here
https://bugzilla.mozilla.org/show_bug.cgi?id=538821

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants