Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected text is nearly unperceivable in Light theme #5

Open
Nakashio opened this issue Oct 10, 2016 · 4 comments
Open

Selected text is nearly unperceivable in Light theme #5

Nakashio opened this issue Oct 10, 2016 · 4 comments

Comments

@Nakashio
Copy link

The text background color change is hard to notice, as the color is close to the normal background color. Probably not intended...

@Nakashio
Copy link
Author

Similar but not quite as bad with selected braces color ("Brace highlight style").

@drenze
Copy link

drenze commented Sep 12, 2018

I observed the same issue for the light theme. I resolved it by changing the bgColor value in the following line:

    <WidgetStyle name="Selected text colour" styleID="0" bgColor="FDF8E9" />

to EEE8D5, which is the code for the "Base2" background tone. This is still a subtle shading, but it works well for me.

@Nakashio
Copy link
Author

Been a long while, but hey, thanks for replying. :)

As for myself, for the selected text color background I went with white (noticeable though not quite as pretty). Playing with it, shades of non-dark gray can also work well, as does your 'light brown'-ish color (I'd probably use a slightly darker version of it to be more noticeable without straining my eyes).
And for the brace highlight style I just went with an obvious orange (rgb 255,128.0), even outright red would work and might possibly be better I suppose.

@drenze
Copy link

drenze commented Sep 14, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants