Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EFO and MONDO terms displayed instead of condition names. #129

Closed
lwaldron opened this issue Mar 28, 2022 · 8 comments
Closed

EFO and MONDO terms displayed instead of condition names. #129

lwaldron opened this issue Mar 28, 2022 · 8 comments
Assignees

Comments

@lwaldron
Copy link
Member

I was just checking out the "filter" option for today's featured taxon Veillonella dispar, and under "Condition" I noticed EFO:0000685 and MONDO:0005178. Should these be shown as rheumatoid arthritis and osteoarthritis instead? It looks like they were entered as the EFO and MONDO terms on https://bugsigdb.org/Study_529, and are also shown as term IDs there.

This seems related to #111, with the over-arching solution being to always display the primary ontology term name.

@tosfos
Copy link
Collaborator

tosfos commented Mar 28, 2022

Right now we don't support entering the IDs in those fields. Also they are not listed as "synonyms" on the glossary pages, so our work on #111 wouldn't address this either. Really, users should be entering the names of these conditions instead of IDs. Is that correct? Or should we add some sort of system that would allow entering IDs?

@lwaldron
Copy link
Member Author

Or maybe a syntax check? Perhaps body site and condition are two fields that we should require valid entry for.

@tosfos
Copy link
Collaborator

tosfos commented Mar 28, 2022

We can do that. That would mean that users can ONLY enter terms that are already page titles in the Glossary. That would mean that they can't enter any new Conditions or Body sites unless they first create a Glossary page.. Please confirm we should go ahead with this.

@lwaldron
Copy link
Member Author

Do we already have glossary pages for the full Uberon and EFO ontologies, or only for terms referred to in bugsigdb experiments?

@tosfos
Copy link
Collaborator

tosfos commented Mar 31, 2022

We only have the 40,000 terms that were in the CSV

@lwaldron
Copy link
Member Author

lwaldron commented Apr 1, 2022

Right - in that case it seems like we should be able to lock down body site and condition allowed values, because I would expect data entry errors to far outnumber need for anything not in those ontologies...

@tosfos
Copy link
Collaborator

tosfos commented May 13, 2022

My mistake. The form already only allows adding existing terms. In this case, the issue was because a user actually added Glossary terms with these titles:
https://bugsigdb.org/EFO:0000685
https://bugsigdb.org/MONDO:0005178

I think the solution is to rename those pages and then include the new titles via the form here and here.

@lwaldron
Copy link
Member Author

Sounds good, and that's nice to hear that the condition and body site entries are already locked down. Since the https://bugsigdb.org/Osteoarthritis and https://bugsigdb.org/Rheumatoid_arthritis glossary terms exist already I just deleted those two ontology term pages (didn't seem possible to rename them anyways).

I just created Issue #136 to ask a question about possible future infrastructure for validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants