Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hook to subscribe to events #27

Open
1 task
weboko opened this issue Oct 15, 2023 · 3 comments
Open
1 task

feat: hook to subscribe to events #27

weboko opened this issue Oct 15, 2023 · 3 comments
Labels
E:Presentation Readiness See https://github.com/waku-org/pm/issues/95 for details enhancement New feature or request

Comments

@weboko
Copy link
Collaborator

weboko commented Oct 15, 2023

Some projects require to subscribe to raw waku/libp2p events.

  • add hook to subscribe to event by name;
@weboko weboko added the enhancement New feature or request label Oct 15, 2023
@weboko weboko added this to Waku Oct 15, 2023
@weboko weboko added the E:Presentation Readiness See https://github.com/waku-org/pm/issues/95 for details label Oct 16, 2023
@danisharora099
Copy link
Contributor

I'm of the favour to expose these libp2p events through a Waku API as a wrapper over the libp2p events

@weboko weboko moved this to To Do in Waku Oct 17, 2023
@danisharora099
Copy link
Contributor

I'd move this to js-waku and have it part of the API

@weboko
Copy link
Collaborator Author

weboko commented Oct 28, 2023

I think there are multiple ways to approach it and we can decide which one will be first.

  • (1) expose some of the libp2p API in @waku/react;
  • (2) expose in js-waku by some abstraction if needed;
  • (3) adapt hook to new abstraction or keep using waku.libp2p directly;

1 and 2 can come in different order

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:Presentation Readiness See https://github.com/waku-org/pm/issues/95 for details enhancement New feature or request
Projects
Status: To Do
Development

No branches or pull requests

2 participants