Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: inconsistent protocol peer management #2147

Closed
danisharora099 opened this issue Sep 30, 2024 · 0 comments · Fixed by #2137
Closed

bug: inconsistent protocol peer management #2147

danisharora099 opened this issue Sep 30, 2024 · 0 comments · Fixed by #2137
Assignees
Labels
bug Something isn't working

Comments

@danisharora099
Copy link
Collaborator

This is a bug report

Problem

The current implementation showcased a lot of inconsistencies around peer management for protocols.
Multiple weird behaviour were observed:

  • protocol not able to find new peers from available pool, while it truly existed
  • peer renewal for a protocol was unsuccessful about the Peer Manager count didn't reflect that
  • protocol sometimes showed a count of available peers much greater than the total actually connected peers

Proposed Solutions

Implement thread-safe management using mutex locks

@chair28980 chair28980 added this to Waku Sep 30, 2024
@weboko weboko moved this to Triage in Waku Sep 30, 2024
@weboko weboko added the bug Something isn't working label Oct 7, 2024
@danisharora099 danisharora099 moved this from Triage to In Progress in Waku Oct 9, 2024
@danisharora099 danisharora099 self-assigned this Oct 10, 2024
@github-project-automation github-project-automation bot moved this from Code Review / QA to Done in Waku Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants