-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: better create protocol options #2073
Labels
enhancement
New feature or request
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a feature request
Problem
Currently options for creating a node are convoluted and spread in the code base.
It get harder to handle and requires some TS hacks to prevent from compilation.
Proposed Solutions
For starters we should split
building
of options andcreation
oflibp2p
which is main consumer of options.Second step is to consolidate leftover option updates specific for
WakuNode
:js-waku/packages/sdk/src/waku.ts
Line 96 in 9b0f1e8
Notes
Draft PR: #2072
The text was updated successfully, but these errors were encountered: