Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

판모달 이상해짐 #551

Closed
yongbeomkwak opened this issue May 31, 2024 · 0 comments · Fixed by #621
Closed

판모달 이상해짐 #551

yongbeomkwak opened this issue May 31, 2024 · 0 comments · Fixed by #621
Assignees
@KangTaeHoon
Labels
0️⃣ Priority: Critical 우선순위 긴급 🐞 Bug 버그 관련

Comments

@yongbeomkwak
Copy link
Member

yongbeomkwak commented May 31, 2024 •
edited by KangTaeHoon
Loading

설명

이슈: slackhq/PanModal#202

sol1) PanModal을 포크떠서 직접 유지보수
sol2) SwiftEntryKit으로 변경
sol3) 바텀시트 직접 구현
sol4) 순정 바텀시트는 iOS16 버전부터 사용 가능한데, 커스텀 범위도 확실하진 않음
sol5) 다른 라이브러리로 대체

최종: sol??

추가사항

No response
@yongbeomkwak yongbeomkwak added the 🐞 Bug 버그 관련 label May 31, 2024
@KangTaeHoon KangTaeHoon self-assigned this Jun 10, 2024
@youn9k youn9k added the 0️⃣ Priority: Critical 우선순위 긴급 label Jun 11, 2024
KangTaeHoon added a commit that referenced this issue Jun 17, 2024
@KangTaeHoon
♻️ :: [#551] PanModal > FittedSheets
e18464f
@KangTaeHoon KangTaeHoon mentioned this issue Jun 17, 2024
Merged
5 tasks
KangTaeHoon added a commit that referenced this issue Jun 18, 2024
@KangTaeHoon
💄 :: [#551] 레이아웃 수정
10d0f95
KangTaeHoon added a commit that referenced this issue Jun 18, 2024
@KangTaeHoon
💄 :: [#551] �safeArea bottom 레이아웃 조건 해제
62d0a0a
KangTaeHoon added a commit that referenced this issue Jun 18, 2024
@KangTaeHoon
🔥 :: [#551] PanModal 관련코드 제거
38cea17
KangTaeHoon added a commit that referenced this issue Jun 18, 2024
@KangTaeHoon
♻️ :: [#551] showFittedSheets() > showBottomSheet()로 래핑
b204cf9
KangTaeHoon added a commit that referenced this issue Jun 18, 2024
@KangTaeHoon
♻️ :: [#551] 코드정리
f998511
KangTaeHoon added a commit that referenced this issue Jun 18, 2024
@KangTaeHoon
Merge pull request #621 from wakmusic/551-fix-panmodal
19e1eed 
🔀 :: (#551) PanModal 라이브러리를 FittedSheets로 대체
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KangTaeHoon KangTaeHoon

Labels
0️⃣ Priority: Critical 우선순위 긴급 🐞 Bug 버그 관련
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🔀 :: (#551) PanModal 라이브러리를 FittedSheets로 대체 wakmusic/wakmusic-iOS
3 participants
@KangTaeHoon @yongbeomkwak @youn9k