Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New search dialog is quite thin on small devices #303

Open
lb- opened this issue Nov 6, 2024 · 3 comments
Open

New search dialog is quite thin on small devices #303

lb- opened this issue Nov 6, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@lb-
Copy link
Member

lb- commented Nov 6, 2024

The new Read The Docs search adoption seems much simpler, however, the layout and styling needs some work.

Especially how thin it is on small devices.

Image

Something like width: min(95vw, 55rem); should be good for the .content but I am not sure if we can easily control these styles as it's in a custom component.

Also, I am not sure if the styles sass/_component_search.scss are still used, we should probably delete or clean up that file if it's not being used. Depending on how we want to tackle the responsibility of this theme to cover custom search still.

Relates to #299

@lb- lb- added the bug Something isn't working label Nov 6, 2024
@laymonage
Copy link
Member

This might be something to raise at https://github.com/readthedocs/addons.

Also, I am not sure if the styles sass/_component_search.scss are still used, we should probably delete or clean up that file if it's not being used. Depending on how we want to tackle the responsibility of this theme to cover custom search still.

We can't assume the docs are hosted on RTD, so this still has some value. Unless we want to just use the built-in search.html page from Sphinx.

@lb-
Copy link
Member Author

lb- commented Nov 6, 2024

Good call about the different searching approaches.

I've not seen a bug on readthedocs add-ons that's the same as this but here's two similar ones.

readthedocs/addons#419

readthedocs/addons#292

I'll look at making a seperate bug on that repo soon.

@lb-
Copy link
Member Author

lb- commented Nov 6, 2024

Issue raised. readthedocs/addons#423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants