Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extraction error due to string culture differences #903

Open
Sederien opened this issue Jun 2, 2020 · 8 comments
Open

Extraction error due to string culture differences #903

Sederien opened this issue Jun 2, 2020 · 8 comments
Labels
bug Something isn't working

Comments

@Sederien
Copy link

Sederien commented Jun 2, 2020

Describe the bug
During install of a list, the installer may fail due to a mod similar to Rayek's End having a degree symbol in one of its filenames. When extracting, the expected filename isn't as expected due to Windows interpreting the symbol natively in another language.

Within Rayek's End - SSE Expanded Edition 1.7-8285-1-7.zip as an example, there is the archived file "Meshes\Oaristys\Clutter\Mirror°.nif" which is expected by WJ... but when a Windows10 install with Japanese base (note: ENGLISH is used as main, but Windows may still interpret symbols differently) it reads the file as "Meshes\Oaristys\Clutter\Mirror・nif" which does not match. Thus, the installation fails.

Additional context
OS (Win 10 Japan running English as main) and Game type (SSE)

Logs
Wabbajack 2020-06-01 16_48_16.log

Above is reinstall attempt, below is after manually extracting and renaming the file in question to the expected "Meshes\Oaristys\Clutter\Mirror°.nif" within the mod directory in profile.

Wabbajack 2020-06-01 16_56_44.log

@erri120 erri120 changed the title Install Error Due to Degree Symbol in Mod Archive on Asia-based OS Extraction error due to string culture differences Jun 9, 2020
@erri120
Copy link
Member

erri120 commented Jun 9, 2020

https://github.com/wabbajack-tools/wabbajack/blob/master/Wabbajack.VirtualFileSystem/Context.cs#L221
Might have to implement custom key finder/string comparer that is string culture independent.

@Tobermann459
Copy link

I have the Same Problem how do i fix it? when i rename the file it just downloads it wrong again i just cant figure out how to do this

@Sederien
Copy link
Author

I have the Same Problem how do i fix it? when i rename the file it just downloads it wrong again i just cant figure out how to do this

See here:
ForgottenGlory/Living-Skyrim-2#69

@Sederien
Copy link
Author

Whoops. Wrong button. Still low priority.

@Sederien Sederien reopened this Aug 27, 2020
@github-actions
Copy link

Marked as stale due to inactivity

@github-actions github-actions bot added the Stale label Jul 29, 2021
@github-actions
Copy link

github-actions bot commented Aug 6, 2021

Closed due to inactivity

@github-actions github-actions bot closed this as completed Aug 6, 2021
@UltraHex
Copy link

This is still a bug.

Why close issues due to inactivity? Just leave them labeled as stale.

@UltraHex
Copy link

UltraHex commented Aug 23, 2024

Want activity to keep bugs open? Have a datapoint:

Wabbajack version: v3.7.1.1
Modpack: https://www.nexusmods.com/skyrimspecialedition/mods/76466?tab=files&file_id=534208
Offending archive: https://www.nexusmods.com/skyrimspecialedition/mods/119731?tab=files&file_id=502388
My OS: Windows 11
My system locale: English (Canada)
Modpack's probable system locale: English (United States)

Error:
[ERROR] (Wabbajack.InstallerVM) Sanity check error extracting D:\Modding\Bethesda\Skyrim SE\Downloads\Soule-like Music-119731-1-0-1716042065.zip - 65 results, expected 66|System.Exception: Sanity check error extracting D:\Modding\Bethesda\Skyrim SE\Downloads\Soule-like Music-119731-1-0-1716042065.zip - 65 results, expected 66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants