Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default task limits should be based on memory and core count, not only core count #2617

Open
AaronFriel opened this issue Sep 17, 2024 · 0 comments
Open

Default task limits should be based on memory and core count, not only core count #2617

AaronFriel opened this issue Sep 17, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@AaronFriel
Copy link

AaronFriel commented Sep 17, 2024 •
edited
Loading

Describe the bug

Wabbajack by default is using 112GiB of memory, or around 1.75GiB per logical CPU on this machine.

image

Additional Context

This computer has an AMD CPU with 64 logical cores. The default of using 64 tasks seems to result in fairly poor performance. Perhaps the default task limits should be determined by say, max(logical cores, gigabytes of RAM / 4)?

Wabbajack version is 3.7.2.1.
@tr4wzified tr4wzified added the bug Something isn't working label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AaronFriel @tr4wzified