-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grant management webapp milestone1 delivery #970
Conversation
@lawmeskiviahs thank you for the milestone delivery. Please see the evaluation document and provide proper answers and fixes. Let me know when I can continue the evaluation. |
@dsm-w3f Thankyou for your evaluation. We have made some changes to the repository. You may continue the evaluation on the master branch of the repository. Updates have been made to the documentation. I hope you'll find everything you need in the docs :D Environment Variables Setup GuideThis guide will help you set up your development environment for testing the code using docker-compose. We'll be using the Step 1: Clone the Repository
Step 2: Copy and Configure the Environment Variables
Step 3: Fill in the Environment VariablesOpen the General configuration
Github configurations
Step 4: Save and Run
Step 5: Test
This guide has also been added to the documentation of the repository. If you encounter issues or need further assistance, please feel free to write to me at
|
pinging @dsm-w3f |
@lawmeskiviahs thank you for the improvements and fixes. I checked again and now I was able to run the application. It works, however there are some doubts and improvement suggestions. Please see the evaluation document for details. Let me know when I can continue this evaluation. |
Thank you @dsm-w3f evaluating the delivery again. The changes you suggested have been done. Please continue with your evaluation.
|
@lawmeskiviahs thank you for the improvements and fixes. I tested again and most of my comments were fixed/improved. Please see the evaluation document for details. The milestone is accepted. I'll forward your invoice internally and the payment should take place within two weeks. Great job! Just a final comment. I think the application is becoming good and with minor adjustments could be possible to try to use it in practice. I'll try to gather more feedback from other members of the grants team. We can try to discuss possible improvements in your next grant application, if you plan to do it. |
We noticed that this is the last milestone of your project. Congratulations on completing your grant! 🎊 |
@lawmeskiviahs, I noticed that your grant application lists DOT as payment, which we don't support. You can choose USDT payment on Polkadot Asset Hub. Can you please submit an amendment to provide a different currency and/or payment method as per our application process description? Also, the invoice only lists fiat payment details. If you want to be paid in cryptocurrency, please add the payment address to the invoice. |
Thankyou @semuelle for your observation. In the default delivery message above I have mentioned that the payment address is not the same as the one in the application. Could you please follow the invoice for details on the payment? |
I don't see a comment in that regard. But if you would like to change the payment details, could you submit an amendment to the grant document? It's simple and usually quickly approved; we just want to make sure there is a "paper trail" in case there are questions later. |
Hi @semuelle thanks for merging the CR. Are we good to go now? |
Hey @lawmeskiviahs. We are good to go. It might still take a week for the invoice to be processed. But do let me know if you haven't heard back in a week. |
@semuelle any updates on the payment? |
hi @lawmeskiviahs we transferred the payment on 1st September. Could you check again whether you received it? If not, we will get in touch with our bank to investigate |
Could you send the transaction details, Maybe the receipt or account details from where the payment was made, we will be able to verify the payment using that. |
Hi @RouvenP. We have recieved the payment. Thank-you so much |
great, thanks for the update @lawmeskiviahs |
Milestone Delivery Checklist
Link to the application pull request: w3f/Grants-Program#1766