-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOM state-preserving move #976
Comments
We consider it a mistake in the platform that element movement is handled by removing and then re-inserting nodes. We would prefer if this effort fixed the existing methods rather than adding new methods. Could the designers invest in some more thorough testing to see if this breaks a significant number of pages, rather than just assuming that it will? If changing all of the element-movement methods does break things, perhaps it would be compatible to change only the newer ones that are methods on Thank you for bringing this to us. The WHATWG discussion seems like the right place to dig into the compatibility question, so we're happy to let them take it from here. |
With this flag (AtomicMoveAuto) on, the following Node methods behave like moveBefore in terms of preserving state: Node.before Node.after Node.prepend Node.append Based on this comment from TAG review: w3ctag/design-reviews#976 (comment) This allows us to test if changing the behavior of these functions breaks something for existing sites. Copied the existing WPTs for moveBefore, and refurbished them to use the existing APIs using variants. Bug: 367985626 Change-Id: I1fe5ff063bc11a7d91622ad76ff19db4d6f7ae0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5873233 Reviewed-by: Dominic Farolino <[email protected]> Commit-Queue: Noam Rosenthal <[email protected]> Cr-Commit-Position: refs/heads/main@{#1357837}
With this flag (AtomicMoveAuto) on, the following Node methods behave like moveBefore in terms of preserving state: Node.before Node.after Node.prepend Node.append Based on this comment from TAG review: w3ctag/design-reviews#976 (comment) This allows us to test if changing the behavior of these functions breaks something for existing sites. Copied the existing WPTs for moveBefore, and refurbished them to use the existing APIs using variants. (cherry picked from commit 083da4a) Bug: 367985626 Change-Id: I1fe5ff063bc11a7d91622ad76ff19db4d6f7ae0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5873233 Reviewed-by: Dominic Farolino <[email protected]> Commit-Queue: Noam Rosenthal <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1357837} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5874055 Commit-Queue: Dominic Farolino <[email protected]> Auto-Submit: Noam Rosenthal <[email protected]> Cr-Commit-Position: refs/branch-heads/6723@{#268} Cr-Branched-From: 985f296-refs/heads/main@{#1356013}
This review was discussed at TPAC 2024. |
こんにちは TAG-さん!
I'm requesting a TAG review of DOM state-preserving move.
This is a feature that allows moving elements around the DOM without their state being reset as a result (e.g. iframes won't reload if moved in this manner)
https://chromestatus.com/feature/5135990159835136
Further details:
You should also know that...
A lot of work on this was already done in the WHATWG context, however there is still time until anything is shipped. So this is a good time to also get some input from TAG!
.
The text was updated successfully, but these errors were encountered: