-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
making the "total" field optional in PaymentRequest API #512
Comments
This looks very sensible to me. No further comments from my side |
LGTM2. |
This statement seems wrong:
But in Payment Request they can describe the item being purchased and have that description shown alongside the price. Certainly, users want to see both product names and prices. “Please authorize the purchase of SHINY_SWORD” without saying how much SHINY_SWORD costs seems wrong to me. |
Hi @hober , Note that whether the total is optional or not, it's up to the payment apps to decide whether to show the total price - this proposal doesn't change this behaviour. Whether before or after the proposal, if the payment apps would like to over-charge the users (more than the requested total amount), they can do that. After all, it's the payment apps who have the access to the users' wallets. Also because of that, they would need to show the final charge to the users before the transaction so as to maintain the users' trust. |
Rather than making For cases like ride sharing, where the total amount is unknown at the time of payment authorization, the Seems like if we support both pending totals and optional totals, it becomes more difficult for authors to understand which mechanism is appropriate for a given scenario. |
Let's loop in @danyao and @mgiuca who have been having similar conversations in such places as w3c/payment-request#912. |
And WICG/digital-goods#5. |
@aestes : pending total makes sense only for the use case where the final price charged will be determined at some point in the future, like authorizing a payment for a service such as Uber. |
I agree @maxlgu . It sounds like "pending" has very different semantics to when total would be omitted because it is already known to the server. |
Since the main argument of this feature is for the digital good api, this tag review should merge into that one once it exists. Set this tag review as blocked. |
Hi there, any update on this and the Digital Goods API? Will that be send to TAG review anytime soon? |
Apologies for leaving this one. I thought we had already discussed Digital Goods in TAG, but it seems it was only in the context of this one issue. We will open a TAG review for DG. |
TAG review opened for Digital Goods API: #571 |
@hober did you have any issues with this review issue? It has a dep on Digital Goods, but it would be good to close, if you don't |
@hober this seems to be depending on you? :-) Can you have a look so that we can potentially close this |
We apologize this took so long - we think this has past it's due date, and the other reviewers were happy with this. We are going to close this in the rollups of our VF2F today. |
Hello TAG!
I'm requesting a TAG review of making the "total" field optional in PaymentRequest API.
Given that when Digital Goods API is used with PaymentRequest API, the total amount is unnecessary, we propose to make the “total” field optional in PaymentRequest API spec, along with a few consequent changes.
The text was updated successfully, but these errors were encountered: