Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to "Security and Privacy Guidelines" (omnibus) #209

Closed
mmccool opened this issue Aug 1, 2022 · 11 comments
Closed

Updates to "Security and Privacy Guidelines" (omnibus) #209

mmccool opened this issue Aug 1, 2022 · 11 comments

Comments

@mmccool
Copy link
Contributor

mmccool commented Aug 1, 2022

The "Security and Privacy Guidelines" document has not been updated for a couple years and should be to take account of the new assertions in the new deliverables, and the removal of the Best Practices document (see Issue #208).

See also See also TAG Review of Architecture

@mmccool
Copy link
Contributor Author

mmccool commented Dec 20, 2022

As suggested by @j1y3p4rk I have started a PR were we can collect suggested changes and review comments: PR 210.

To create the PR I had to make a minor change to the doc, so I added a comment the HTML header. We can remove it before merging assuming we make other changes.

@mmccool
Copy link
Contributor Author

mmccool commented Jan 30, 2023

Some things I noticed need fixing:

  • Says WoT is declarative, not prescriptive, but some parts now prescriptive
  • Does not mention Discovery at all
  • Mentions DoS as a threat, but not DDoS
  • Intro section is quite weak, does not define security, and ignores privacy
  • Lifecycle needs to be aligned with Arch (or just reference it)

@mmccool
Copy link
Contributor Author

mmccool commented Jan 30, 2023

  • No references after 2019 (of course), things like OWASP guidelines are published annually
  • Should reference protocol bindings for other protocols rather than focusing on CoAP/HTTP/MQTT
  • No mention of DID, SSI, other key distribution mechanisms

@mmccool
Copy link
Contributor Author

mmccool commented Jan 30, 2023

Discussion in Security TF call Jan 30:

  • End-to-end security mentions TD signing, but we have no good way to do that
  • "Secure practices for..." is a bit redundant, can simplify titles
  • "Requirements" section is not really requirements, consider a different name (perhaps "Analysis")
  • Protocol-specific comments in secure transport really about TLS/DTLS, which are a separate layer from protocols (e.g. can have OPC UA over these secure transports, too...)
  • Need to refactor to figure what goes where in new charter; a lot of overlap with security and privacy considerations in other documents, lifecycle is out of place, etc.
  • Can we fix anything in this charter, or do we have to wait until the next charter?
  • Quick fixes:
    - Update references, esp IETF versions, OWASP, e.g. things that are normally updated (Jiye) Add and Update Cloud References #206
    - Mention new deliverables - Discovery & Profiles, and Arch 1.1 and TD 1.1 (McCool) Mention new deliverables #211
    - Revise abstract to be more in line with Architecture wrt "descriptive" vs. "prescriptive", and generally position the document better (McCool) Revise abstract #215
    - Expand the (currently very short) intro section (Jan) Expand the (currently very short) intro section  #214
    - Rename "Requirements" section (-> Analysis) (Jiye) Rename "Requirements" section to "Analysis" #213
    - Add DDoS threat (McCool) Add DDoS threat  #212
    - See what's going on with Lifecycle; was it supposed to have been moved to Arch and we just didn't delete it here yet? (McCool) Review updated Lifecycle in Architecture #192

@mmccool
Copy link
Contributor Author

mmccool commented Jan 30, 2023

Other:

  • Maybe add a workitem to "align security and privacy considerations across deliverables" to next WG charter? These should be aligned with the "best practices" mentioned in the S&P Guidelines. In the short term, probably can't do that justice with a full reorg, but we should at least check for contradictions and fix them. (McCool - to wot repo for charter draft)

@j1y3p4rk
Copy link

Additional comments:

  • Need to update 'Chapter 5, References to Existing Security Best Practices'. As written in EDITOR'S NOTE, we don't need to have all references listed.
  • In chapter 7.1, I suggest to change

In case it is not possible to pre-provision any of the types of credentials described above during the network setup phase or if the WoT Thing wants to use a more fine-grained access control policy on the WoT Interfaces it is exposing (for example, different controls might require different levels of authorization), the following methods can be used instead:

to

If the WoT Thing wants to use a fine-grained access control policy on the WoT Interfaces it is exposing (for example, different controls might require different levels of authorization), the following methods can be used instead:

as the types of credentials described above are nothing to do with access control.

@mmccool mmccool changed the title Update "Security and Privacy Guidelines" prior to 2022 PR transitions Update "Security and Privacy Guidelines" prior to 2023 PR transitions Jul 31, 2023
@mmccool
Copy link
Contributor Author

mmccool commented Jul 31, 2023

Test link to threat in S&P Guidelines: https://w3c.github.io/wot-security/#dfn-malicious-authorized-solution-user
See #222

@mmccool mmccool changed the title Update "Security and Privacy Guidelines" prior to 2023 PR transitions Updates to "Security and Privacy Guidelines" (omnibus) Jan 15, 2024
@mmccool
Copy link
Contributor Author

mmccool commented Jan 15, 2024

Factor out the above survey of considerations in to a separate file: #233

@mmccool
Copy link
Contributor Author

mmccool commented Jan 15, 2024

Close this issue, but factor out into other small issues. A number of the things discussed here have already been taken care of. Above PR captures survey. Here is a consolidated list of all the discussion points that have not yet been addressed or for which an issue has not be created:

  • Should reference protocol bindings for other protocols rather than focusing on CoAP/HTTP/MQTT
  • No mention of DID, SSI, other key distribution mechanisms
  • End-to-end security mentions TD signing, but we have no good way to do that
  • Protocol-specific comments in secure transport really about TLS/DTLS, which are a separate layer from protocols (e.g. can have OPC UA over these secure transports, too...)
  • Need to refactor to figure what goes where in new charter; a lot of overlap with security and privacy considerations in other documents, lifecycle is out of place, etc.

Will create one issue just for these points, close this issue.

Here are some points we have outstanding issues for:

  • (abstract) Says WoT is declarative, not prescriptive, but some parts now prescriptive
  • No references after 2019 (of course), things like OWASP guidelines are published annually
  • Does not mention Discovery at all
  • Intro section is quite weak, does not define security, and ignores privacy
  • Lifecycle needs to be aligned with Arch (or just reference it)

Here are some points that we have already addressed:

  • Mentions DoS as a threat, but not DDoS
  • "Secure practices for..." is a bit redundant, can simplify titles
  • "Requirements" section is not really requirements, consider a different name (perhaps "Analysis")

@mmccool
Copy link
Contributor Author

mmccool commented Jan 15, 2024

content has been reorganized into other issues/PRs.

@mmccool mmccool closed this as completed Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants