Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop patches that are no longer needed #336

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Drop patches that are no longer needed #336

merged 1 commit into from
Sep 1, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 1, 2021

dontcallmedom
dontcallmedom approved these changes Sep 1, 2021
View reviewed changes
Copy link
Member

@dontcallmedom dontcallmedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

glad we have this script :)

@tidoust
Copy link
Member

tidoust commented Sep 1, 2021

... but this shouldn't be merged as is until we clean abandoned files properly. Typically, crawl did not update ed/idl/payment-method-basic-card.idl, which still references AddressErrors define in the patch, because that file actually needs to be removed (spec no longer defines any IDL content) and we don't do remove files in Webref automatically.

@tidoust
Copy link
Member

tidoust commented Sep 1, 2021

... but this shouldn't be merged as is until we clean abandoned files properly. Typically, crawl did not update ed/idl/payment-method-basic-card.idl, which still references AddressErrors define in the patch, because that file actually needs to be removed (spec no longer defines any IDL content) and we don't do remove files in Webref automatically.

Done in #338.

@tidoust tidoust merged commit 234293c into master Sep 1, 2021
@tidoust tidoust deleted the clean-patches-1630467330 branch September 1, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dontcallmedom dontcallmedom dontcallmedom approved these changes

Assignees

@dontcallmedom dontcallmedom

@tidoust tidoust

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tidoust @dontcallmedom