Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: API to allow incognito access #658

Closed
erosman opened this issue Jul 17, 2024 · 2 comments
Closed

Proposal: API to allow incognito access #658

erosman opened this issue Jul 17, 2024 · 2 comments
Labels
neutral: safari Not opposed or supportive from Safari opposed: chrome Opposed by Chrome opposed: firefox Opposed by Firefox topic: private browsing

Comments

@erosman
Copy link

erosman commented Jul 17, 2024

Background

Some APIs, like proxy.settings, require incognito permission.

While extensions can enquire extension.isAllowedIncognitoAccess, currently, there is no API for the extension to handle the user option within the extension environment. Extensions are forced to ask users to go to the appropriate browser page in order to allow incognito access.

Proposal

Add an API to enable extensions to requests incognito access from the users (similar to permissions.request())

For example:

// via permissions.request
let permission = await browser.permissions.request({permissions: ['incognito']});
// return true/false

// via own API
let incognito = await browser.extension.requestIncognitoAccess();
// return true/false

See also:

@github-actions github-actions bot added needs-triage: chrome Chrome needs to assess this issue for the first time needs-triage: firefox Firefox needs to assess this issue for the first time needs-triage: safari Safari needs to assess this issue for the first time labels Jul 17, 2024
@xeenon xeenon added neutral: safari Not opposed or supportive from Safari and removed needs-triage: safari Safari needs to assess this issue for the first time labels Jul 18, 2024
@Rob--W
Copy link
Member

Rob--W commented Jul 18, 2024

FYI: starting from Firefox 129, the ability to access private browsing windows is part of the install dialog (https://bugzilla.mozilla.org/show_bug.cgi?id=1842832). Up until Firefox 128, there was a post-install panel from which users can easily grant access to private browsing mode.

After install, it is not obvious for users that their extension is unavailable in private browsing windows.

@Rob--W Rob--W added neutral: firefox Not opposed or supportive from Firefox and removed needs-triage: firefox Firefox needs to assess this issue for the first time labels Jul 18, 2024
@zombie
Copy link
Collaborator

zombie commented Sep 27, 2024

We would like to keep the private browsing permission as something that extensions are not able to trigger, which only the user can manually grant, because that gives the browser more control of the process, and hopefully results in a more informed choice from the user.

Closing the issue, consensus among browser vendors is we don't want this as a feature.

@zombie zombie closed this as completed Sep 27, 2024
@zombie zombie added opposed: firefox Opposed by Firefox and removed neutral: firefox Not opposed or supportive from Firefox labels Sep 27, 2024
@Rob--W Rob--W added opposed: chrome Opposed by Chrome and removed needs-triage: chrome Chrome needs to assess this issue for the first time labels Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
neutral: safari Not opposed or supportive from Safari opposed: chrome Opposed by Chrome opposed: firefox Opposed by Firefox topic: private browsing
Projects
None yet
Development

No branches or pull requests

5 participants