Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistency: Commands API support for Cmd+Alt on Apple OSs #645

Open
rishikramena-ms opened this issue Jun 21, 2024 · 3 comments
Open

Inconsistency: Commands API support for Cmd+Alt on Apple OSs #645

rishikramena-ms opened this issue Jun 21, 2024 · 3 comments
Labels
implemented: firefox Implemented in Firefox implemented: safari Implemented in Safari inconsistency Inconsistent behavior across browsers supportive: chrome Supportive from Chrome topic: commands

Comments

@rishikramena-ms
Copy link

Ctrl+Alt is not considered a valid combination for extension shortcuts in Windows as it interferes with the behavior of the AltGr key and in order to maintain consistency across platforms, we disallow it for Mac as well.

For Chromium in Mac, Cmd key specified for shorcuts in the manifest is normalized to Ctrl key because of which Cmd+Alt is also disallowed in Mac. Firefox allows this Cmd+Alt combination for its extensions shortcuts.

Should we reconsider allowing Cmd+Alt as a valid combination in Mac?
@github-actions github-actions bot added needs-triage: chrome Chrome needs to assess this issue for the first time needs-triage: firefox Firefox needs to assess this issue for the first time needs-triage: safari Safari needs to assess this issue for the first time labels Jun 21, 2024
@dotproto
Copy link
Member

dotproto commented Jul 4, 2024 •
edited
Loading

Tagging @xeenon for broader consideration of OS-specific keyboard shortcut conventions on macOS/iPadOS and current Safari behavior.

@dotproto dotproto added inconsistency Inconsistent behavior across browsers topic: commands labels Jul 4, 2024
@dotproto dotproto changed the title commands API: Revisit allowing Cmd+Alt for Mac in Chromium Inconsistency: Commands API support for Cmd+Alt on Apple OSs Jul 4, 2024
@dotproto
Copy link
Member

dotproto commented Jul 4, 2024

I tweaked the title to adjust the framing. This group tries to avoid browser-specific discussions, but we actively encourage cross-browser collaboration and resolving inconsistencies across browsers.

@dotproto dotproto mentioned this issue Jul 4, 2024
Closed
@xeenon xeenon added implemented: safari Implemented in Safari implemented: firefox Implemented in Firefox and removed needs-triage: safari Safari needs to assess this issue for the first time needs-triage: firefox Firefox needs to assess this issue for the first time labels Jul 4, 2024
@Rob--W Rob--W mentioned this issue Jul 4, 2024
Merged
@oliverdunk oliverdunk added supportive: chrome Supportive from Chrome and removed needs-triage: chrome Chrome needs to assess this issue for the first time labels Sep 27, 2024
@oliverdunk
Copy link
Member

We are supportive of allowing Cmd+Alt as a valid combination for the suggested_key.mac field in Chrome. @rishikramena-ms has some ongoing work here.

@Rob--W Rob--W mentioned this issue Sep 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
implemented: firefox Implemented in Firefox implemented: safari Implemented in Safari inconsistency Inconsistent behavior across browsers supportive: chrome Supportive from Chrome topic: commands
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@xeenon @dotproto @oliverdunk @rishikramena-ms