-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
browsingContext.navigationStarted
for the initial navigation to about:blank
#766
Comments
We can mark those tests as tentative for now: web-platform-tests/wpt#47958 |
We cannot simply ignore all the navigations to But yes, we should discuss and maybe you can add it to the next meeting which probably will be the TPAC one this month? |
Let me clarify: |
I think in principle I'm happy with the idea of trying to ignore the navigation to initial However the technical here are tricky, and I haven't looked in great detail. |
Does the spec actually go through the navigation started hook when creating a new browsing context? I do not seem to be able to confirm that. |
Note that this issue also affects the Which events should we actually emit, and when, during the
Is there anything else we should consider to ensure a smooth and error-free interaction? What are your thoughts on this approach? |
The Browser Testing and Tools Working Group just discussed
The full IRC log of that discussion<AutomatedTester> topic: Emitting Events During "browsingContext.create" when "about:blank" is loaded<AutomatedTester> github: https://github.com//issues/766 <AutomatedTester> scribe+ <AutomatedTester> whimboo: this issue was origianly raised by sadym <AutomatedTester> ... this is about getting an event when the context being created and then when can we navigate <orkon> q+ <AutomatedTester> ... so the question is what do we want to do with the creation of new tabs/documents? <AutomatedTester> ... do we want to handle navigationStarted for about:black? <AutomatedTester> ack orkon <AutomatedTester> orkon: I checked the html spec and I couldn't see if there is a navigationStarted with about:blank <AutomatedTester> ... perhaps we need to reverse the test so it doesn't have the event on about:blank <AutomatedTester> q? <whimboo> q+ <AutomatedTester> ack whimboo <AutomatedTester> whimboo: we are happy to change this <AutomatedTester> ... and this way we can improve the clients so they have a better idea when to work with the tab <jdescottes> q+ <AutomatedTester> ... and I am not sure about the implementation status of these things in chrome and if/when it will be ready <AutomatedTester> ack jdescottes <AutomatedTester> jdescottes: when I was testing this in Firefox we weren't running events for navigation on about:blank <orkon> q+ <AutomatedTester> ... if there are any scenario where we have any extra events in the browser? <AutomatedTester> ack orkon <orkon> https://github.com/web-platform-tests/wpt/pull/47958/files#diff-c773a239b93f48290e8f834f6fd9c337720fb92b206b65e03ce1c64633789032 <jdescottes> q+ <AutomatedTester> whimboo: we fire the created event early... this is a combined question of should we send anything out before the creation of the tab <AutomatedTester> orkon: there are wpt tests that I have linked <AutomatedTester> ... [describes test]. This test wasnt passing in chrome but in Firefox <AutomatedTester> q? <AutomatedTester> ack jdescottes <AutomatedTester> jdescottes: thanks to the link. THe item about the creation event coming out too early... I think we should talk about this. <gsnedders> q? <sadym> This is the mentioned test: https://github.com/web-platform-tests/wpt/pull/47958 <AutomatedTester> ... in firefox we have changed the way that we emit events so that we do it after the creation of the context <AutomatedTester> ack gsnedders <orkon> q+ <AutomatedTester> gsnedders: Are you saying the load is async in firefox? I thought you could always access the document in the iframe in a sync way <AutomatedTester> whimboo: this is for the new top level browser context <AutomatedTester> gsnedders: ok, that wasn't clear in the issue <AutomatedTester> ack orkon <AutomatedTester> orkon: looks like we're talking about 2 different issues. This is about the browserContext creation with about:blank <sadym> https://github.com/web-platform-tests/wpt/pull/47958/files#diff-c773a239b93f48290e8f834f6fd9c337720fb92b206b65e03ce1c64633789032R14-R29 <AutomatedTester> ... in firefox there are navigationStarted events being fired in about;blank <AutomatedTester> sadym: I've linked to the the test <AutomatedTester> q? <AutomatedTester> jgraham: for the case of initial about:blank we should treat it like it is sync <AutomatedTester> ... e.g. create a new tab with about:blank you can start interacting with it straight away <jgraham> jgraham: and not emit a navigation started event <AutomatedTester> gsnedders: is there a use case where that is not about:blank? <AutomatedTester> [discussion about checking we are all started from about:blank and navigationStarted events] <AutomatedTester> whimboo: firefox has 2 events emited for about:blank. a sync and an async event <orkon> q+ <simonstewart> q? <AutomatedTester> ... and we should treat new window creation special if there is a URL in there <AutomatedTester> whimboo: how would window creation handle this? <AutomatedTester> ack orkon <AutomatedTester> orkon: the html spec says there are some special treatment for about blank. e.g. if it has params we need to update the history <AutomatedTester> whimboo: this should be possible for us to do this and not emit the event <AutomatedTester> q? <AutomatedTester> ACTION: sadym to update test to hsow that events are not emited on about:blank |
Note that we are going to update the behavior of Firefox over on https://bugzilla.mozilla.org/show_bug.cgi?id=1922014. |
@sadym-chromium can you please update the related tests so that they actually behave as expected? Thanks. |
I started working on it in web-platform-tests/wpt#48651 |
Analogous to the initial
browsingContext.load
event, it can be confusing, especially if the browsing context is created, navigated toabout:blank
and then navigated to some other URL.From discussion:
Do we need those events for the initial navigation? If not, should we specify an exception?
The text was updated successfully, but these errors were encountered: