-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicit frame drop signal from VideoEncoder #742
Comments
On the other hand, 2 existing implementations drop frames silently, so using the regular output callback as is will be a breaking change. If we ever do this we'll need a VideoEncoderConfig option to turn it on. |
At least Meet is interested in drop frame notifications. |
Currently when a real time encoder drops a frame clients don’t get any signal from VideoEncoder. If they really want to know that a frame was dropped they need to look at the timestamps of the encoded video chunks. This issue can be addressed by a new flag in the encoder config that would cause the encoder to call EncodedVideoChunkOutputCallback for dropped frames with an empty data buffer in the encoded chunk. partial dictionary VideoEncoderConfig {
boolean notifyAboutFrameDrops = false;
} |
@Djuffin When encoding with H.264, am seeing the following messages refer to [OpenH264] this = 0x0x13c05ca6e70, Warning:bEnableFrameSkip = 0,bitrate can't be controlled for RC_QUALITY_MODE,RC_BITRATE_MODE and RC_TIMESTAMP_MODE without enabling skip frame. |
@aboba We have a task for it, but it never got any attention https://issues.chromium.org/issues/40811827 |
Currently the spec doesn't specify any way for VideoEncoder to signal that a frame has been dropped due to
realtime
mode constraints.I think it would be useful to have such a signal.
Possible options:
This came up after WPT test change that accounts for frame drops.
The text was updated successfully, but these errors were encountered: