Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A request's "window" is never a Window #533

Open
jyasskin opened this issue Sep 28, 2023 · 1 comment
Open

A request's "window" is never a Window #533

jyasskin opened this issue Sep 28, 2023 · 1 comment

Comments

@jyasskin
Copy link
Member

Should request be allowed to use feature? has

  1. Set window to request’s window.
  2. If window is not a Window, return false.

However, request's window is '("no-window", "client", or an environment settings object whose global object is a Window object)'. That is, it can be an environment settings object, but it can't be a Window. This is confusing, but makes the algorithm here wrong.

@annevk
Copy link
Member

annevk commented Sep 29, 2023

Yeah, I'd recommend using

If window is "no-window", then return false.

if you really mean that. But note that window can be set for requests that pass through a service worker. If you really care about the environment that's currently making the request, you want client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants