Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create page footers for example pages #32

Closed
shawna-slh opened this issue Apr 8, 2022 · 10 comments
Closed

Create page footers for example pages #32

shawna-slh opened this issue Apr 8, 2022 · 10 comments

Comments

@shawna-slh
Copy link
Contributor

Most WAI pages have a page footer in additional to the site-wide footer. It is used for info like updated date and acknowledgements.

Maybe put this for after launch?

@mcking65
Copy link
Contributor

mcking65 commented May 3, 2022

We need this on the example pages to resolve #45

This is also probably the best place to include the "Related Issues" link that is unique for every example page; it links to the GitHub project containing all the issues related to the example.

@richnoah could we please size creating a very simple footer for example pages only with content something like:

Page last updated: April 22, 2022
View issues related to this example

For initial launch, we could use the most recent commit date for the html file itself. Eventually, we'd need to get a bit more sophisticated and also look at the commits on the js and css linked from the header.

There is more we could consider for the footer after launch.

@mcking65 mcking65 changed the title footers Create page footers for example pages May 3, 2022
@s3ththompson
Copy link
Member

We decided to use this footer as the new home for Related Issues (rather than "Help improve this page"). See Matt's comment above.

@shawna-slh
Copy link
Contributor Author

Just a reminder that unless there is a reason not to, please use the date format from the main WAI website resource template:

Date: Updated @@ Month 2022.

@mcking65
Copy link
Contributor

I have reviewed the preview of #62, and this issue is not yet addressed.

There is a time stamp at the end of main. That timestamp is inside of main instead of being present in a footer with an accessible name of "Page". Also, the "related issues" link is not present.

I'm moving this back to in-progress.

@mcking65
Copy link
Contributor

Verified fixed in #62!!

@shawna-slh
Copy link
Contributor Author

On some pages, I am seeing the wrong date intro and wrong date format, e.g.,

Page last updated: November 23, 2021

On others, no date at all.

I think we agreed this is not required for launch. I want to make sure it is left on the list to address soon.


I also want to check more broadly whether we want (or even should have) more acknowledgements on every page, which is a main purpose of the page footer throughout the WAI website.

@mcking65
Copy link
Contributor

@shawna-slh wrote:

On some pages, I am seeing the wrong date intro and wrong date format, e.g.,

Page last updated: November 23, 2021

On others, no date at all.

I think we agreed this is not required for launch. I want to make sure it is left on the list to address soon.

Yes, for launch, we are aiming for page footers only on example pages containing a date and link to related issues.

We want the option to put the related issues link in the feedback section. Then, we can revise the page footer.

I also want to check more broadly whether we want (or even should have) more acknowledgements on every page, which is a main purpose of the page footer throughout the WAI website.

I opened #87

@shawna-slh
Copy link
Contributor Author

Having proper date format seems not too hard to do? I know it's a little thing -- yet, the kind of thing that will niggle at some people... asking for a friend {wink}

And I like to avoid putting things out there that folks can legitimacy criticize us for not following our own guidance / style

@mcking65
Copy link
Contributor

@richnoah I moved this back to in-progress. Can we please just take a quick look at the date format requirements referenced by @shawna-slh?

@shawna-slh wrote:

Just a reminder that unless there is a reason not to, please use the date format from the main WAI website resource template:

Date: Updated @@ Month 2022.

@shawna-slh
Copy link
Contributor Author

Thanks Matt.

To be more clear:

  • I care less about "Page last updated:... " vs "Date: Updated ..."
  • I care more about the international date format as prescribed in the WAI style guide:

@@ Month 20@@

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants