-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create page footers for example pages #32
Comments
We need this on the example pages to resolve #45 This is also probably the best place to include the "Related Issues" link that is unique for every example page; it links to the GitHub project containing all the issues related to the example. @richnoah could we please size creating a very simple footer for example pages only with content something like:
For initial launch, we could use the most recent commit date for the html file itself. Eventually, we'd need to get a bit more sophisticated and also look at the commits on the js and css linked from the header. There is more we could consider for the footer after launch. |
We decided to use this footer as the new home for Related Issues (rather than "Help improve this page"). See Matt's comment above. |
Just a reminder that unless there is a reason not to, please use the date format from the main WAI website resource template:
|
I have reviewed the preview of #62, and this issue is not yet addressed. There is a time stamp at the end of main. That timestamp is inside of main instead of being present in a footer with an accessible name of "Page". Also, the "related issues" link is not present. I'm moving this back to in-progress. |
Verified fixed in #62!! |
On some pages, I am seeing the wrong date intro and wrong date format, e.g.,
On others, no date at all. I think we agreed this is not required for launch. I want to make sure it is left on the list to address soon. I also want to check more broadly whether we want (or even should have) more acknowledgements on every page, which is a main purpose of the page footer throughout the WAI website. |
@shawna-slh wrote:
Yes, for launch, we are aiming for page footers only on example pages containing a date and link to related issues. We want the option to put the related issues link in the feedback section. Then, we can revise the page footer.
I opened #87 |
Having proper date format seems not too hard to do? I know it's a little thing -- yet, the kind of thing that will niggle at some people... asking for a friend {wink} And I like to avoid putting things out there that folks can legitimacy criticize us for not following our own guidance / style |
@richnoah I moved this back to in-progress. Can we please just take a quick look at the date format requirements referenced by @shawna-slh? @shawna-slh wrote:
|
Thanks Matt. To be more clear:
|
Most WAI pages have a page footer in additional to the site-wide footer. It is used for info like updated date and acknowledgements.
Maybe put this for after launch?
The text was updated successfully, but these errors were encountered: