Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up: consolidate documentLoader and didResolvers #82

Open
aljones15 opened this issue May 28, 2024 · 0 comments
Open

clean up: consolidate documentLoader and didResolvers #82

aljones15 opened this issue May 28, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@aljones15
Copy link
Contributor

  1. the documentLoader should be an async function that accepts a url and returns a document
  2. the existing documentLoader in the tests dir has a parameter {url} that should just be url
  3. the existing documentLoader in the tests dir does not use jsonld-document-loader
  4. the existing documentLoader uses didResolver.js which can be rolled into jsonld-document-loader
  5. increasingly this project has multiple documentLoaders these can be consolidated into a single function that creates a documentLoader, that function should come from data-integrity-test-suite-assertion or vc-test-suite-implementations at some point so other projects can create a documentLoader with support for a particular did:key type.
  6. the documentLoader in tests should be removed or moved somewhere else
@aljones15 aljones15 added the enhancement New feature or request label May 28, 2024
@aljones15 aljones15 self-assigned this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant