Editorial: small cleanup of examples #263
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use async/await in both examples. Use nullish coalescing.
marcoscaceres
commented
Nov 22, 2023
| PaymentRequest && | ||
| PaymentRequest.isSecurePaymentConfirmationAvailable && | ||
| await PaymentRequest.isSecurePaymentConfirmationAvailable(); | ||
| await PaymentRequest?.isSecurePaymentConfirmationAvailable(); |
There was a problem hiding this comment.
This is cool, I've never seen it before!
I think it's technically optional chaining (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining) rather than nullish coalescing (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Nullish_coalescing), right?
Does this work as written if PaymentRequest itself is not defined? (As opposed to isSecurePaymentConfirmationAvailable not being defined). It seemed not when I tried it in Firefox, but I may have been holding it wrong. I had to do:
window.PaymentRequest?.isSecurePaymentConfirmationAvailable();
Without the window, I just got:
PaymentRequest?.isSecurePaymentConfirmationAvailable()
Uncaught ReferenceError: PaymentRequest is not defined
<anonymous> debugger eval code:1
debugger eval code:1:1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use async/await in both examples. Use nullish coalescing.
Preview | Diff