Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spec] Write the 'transaction UX' section #114

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

stephenmcgruer
Copy link
Collaborator

@stephenmcgruer stephenmcgruer commented Aug 23, 2021

The goal here is to enforce that User Agents do communicate the necessary
information that will be signed over, but not to restrict their implementation
of how to do so.


Preview | Diff

The goal here is to enforce that User Agents do communicate the necessary
information that will be signed over, but not to restrict their implementation
of how to do so.
@stephenmcgruer
Copy link
Collaborator Author

@domfarolino - I've straw-personed some minimal text here as a starting point. I'd love your thoughts on the best way to specify this without constraining UAs.

Payment Confirmation payment handler=] is selected. However, so that a
[=Relying Party=] can trust the information included in
{{CollectedClientPaymentData}}, the User Agent MUST ensure that the following
is communicated to the user:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! It is a tad COMEFROMey, so it might be nice to define an algorithm here that communicates the above-mentioned information in some UA way, and then invoking that algorithm from show(), but I think this is sufficient.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree! Unfortunately Payment Request is implemented such that there is no actual concrete place where the payment handler 'takes over' :/

show():

So there's not really anything to hook onto here :(. If when we move away from Payment Request, I hope to make this more GOTO rather than COMEFROM :)

@stephenmcgruer stephenmcgruer merged commit 0584229 into main Aug 26, 2021
@stephenmcgruer stephenmcgruer deleted the smcgruer/spec-displaying-a-ux branch August 26, 2021 15:53
github-actions bot added a commit that referenced this pull request Aug 26, 2021
SHA: 0584229
Reason: push, by @stephenmcgruer

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants