Add regionCode attribute to PaymentAddress (1.1) #836
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this for 1.0 or 1.1+? |
|
1.1 |
|
Blocked on release of 1.0. |
|
Ok, tests and spec are resurrected for when when want this... |
|
@danyao or @rsolomakhin, if you have a bug on the Chromium side, could you please add it to the top of the bug? |
|
Linked the Chrome bug. |
rsolomakhin
approved these changes
Mar 6, 2019
|
Mucho appreciated! |
added 2 commits
April 10, 2019 12:14
marcoscaceres
force-pushed
the
regioncode_redux
branch
from
b0b4e23
to
d956ac7
Compare
|
Similarly here, we need commitment from another implementer to land this. |
marcoscaceres
changed the title
|
No moar PaymentAddress with #955 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "Remove regionCode attribute (#823)"
This reverts commit 5906b72.
closes w3c/contact-picker#65
The following tasks have been completed:
Implementation commitment:
Optional, impact on Payment Handler spec?
Preview | Diff
Preview | Diff