Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leftovers regarding modifiers in CanMakePaymentEvents #378

Open
SECtim opened this issue Nov 18, 2020 · 0 comments
Open

Leftovers regarding modifiers in CanMakePaymentEvents #378

SECtim opened this issue Nov 18, 2020 · 0 comments

Comments

@SECtim
Copy link

SECtim commented Nov 18, 2020

Hi,

after I scratched my head for quite a while over why there are both methodData and modifiers, I stumbled across #289, which explained it for me. While this might be a candidate for some clarification in the specs (unless I overlooked an existing explanation), this issue is about the following lines in the Payment Handler API (both in the Can Make Payment section):

<dfn>methodData</dfn>, and <dfn>modifiers</dfn> members share their

payment-handler/index.html

Lines 988 to 994 in 4b4525f

<dt>
<a data-lt="CanMakePaymentEvent.modifiers">modifiers</a>
</dt>
<dd>
The result of executing the <a>Modifiers Population
Algorithm</a>.
</dd>

These seem to be leftovers from before #289 / #315 - if my understanding is correct, these should be removed as well.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant