Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workerStart should be gated on same-origin check #99

Closed
yoavweiss opened this issue Dec 20, 2018 · 5 comments
Closed

workerStart should be gated on same-origin check #99

yoavweiss opened this issue Dec 20, 2018 · 5 comments

Comments

@yoavweiss
Copy link
Contributor

Spinoff from w3c/resource-timing#118

workerStart exposes new information, so in the case of navigation redirects it should not be exposed unless all the redirects pass the timing-allow check.

@yoavweiss yoavweiss added this to the Level 2 milestone Mar 8, 2019
@yoavweiss
Copy link
Contributor Author

/cc @nhelfman

@yoavweiss
Copy link
Contributor Author

As discussed in #104, we're moving away from Timing Allow checks towards same-origin checks for Navigation Timing.

@yoavweiss yoavweiss changed the title workerStart should be gated on timing-allow check workerStart should be gated on same-origin check Jun 26, 2019
@yoavweiss yoavweiss self-assigned this Aug 1, 2019
@yoavweiss yoavweiss added the WPT label Sep 4, 2020
@nicjansma
Copy link

Addressed in #131.

Note that change does not use the "same-origin check" directly, as that would 0 out workerStart (which only exposes data about the current origin) whenever the navigation starts from another origin. This would make workerStart not very valuable in cases like clicks to a page from a search result page.

The "same-origin check" would also leave this as 0 if there were any cross-origin redirects before the final origin (whether that final origin has redirects or not).

Since workerStart is only information about the final origin, it shouldn't need the same level of protection as the "same-origin check", we just want to make sure workerStart doesn't leak anything about the previous cross origins (e.g. from cross-origin redirects before the final origin).

Instead, we define workerStart as the startup time of the SW for the final origin (and the first request of those if it has redirects).

@noamr
Copy link
Contributor

noamr commented Oct 3, 2021

See #160 and related issues.

@noamr
Copy link
Contributor

noamr commented Mar 20, 2022

Closing. I don't think this issue needs to be handled separately from #160

@noamr noamr closed this as completed Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants