Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light Indicator #67

Open
knyg opened this issue Jan 15, 2018 · 5 comments · May be fixed by #143
Open

Light Indicator #67

knyg opened this issue Jan 15, 2018 · 5 comments · May be fixed by #143

Comments

@knyg
Copy link
Collaborator

knyg commented Jan 15, 2018

Many controllers support the concept of a light indicator to represent the player index of a controller. This is helpful to the user to know which player character is being controlled without testing each controller. Additionally, some games are only playable using a controller with a specific player index. In the context of VR, controllers may support a light indicator to assist the application in determining the location of the player. Light indicators range from monochrome light indicators (ON/OFF) to RGB light indicators.

We'd like to bring gamepad extension support to the same level of support provided by native functionality with the following proposal: Light Indicator Proposal

Please let us know if you have any questions, comments, or feedback.

@nondebug
Copy link
Collaborator

@knyg:

"monochrome" suggests that the light supports varying shades of one color, but the API only allows it to be fully-on or fully-off. Could we rename this to something like "on-off" or "binary" to make this clearer?

The proposal exposes the current indicator color as a property of the light indicator, but I'm not sure that this is always possible to query from the device. Supporting this for devices that don't expose the indicator state will require encoding device-specific details into the user agent to either guess at the initial value or set it to a reasonable default on connection. Can we do without it?

@knyg
Copy link
Collaborator Author

knyg commented Jan 22, 2018

@nondebug

"monochrome" suggests that the light supports varying shades of one color

Agreed, "on-off" will be clearer.

Good point about obtaining the current color. I think it can safely be removed since setting the color will return a Promise, indicating whether the color was set correctly.

@knyg
Copy link
Collaborator Author

knyg commented Feb 5, 2018

@nondebug

Proposal updated with suggestions - light indicator updates

@sgraham sgraham added the v2 label Feb 14, 2018
@haykam821
Copy link

Some gamepads (such as Nintendo Switch with light ring on home button) have a button associated with a light or backlighting in general. Perhaps this can be expanded to include null (for no lighting on a button) or that light, so we can toggle a light from its button?

@fernando-80
Copy link
Contributor

Some gamepads (such as Nintendo Switch with light ring on home button) have a button associated with a light or backlighting in general. Perhaps this can be expanded to include null (for no lighting on a button) or that light, so we can toggle a light from its button?

@haykam821 according to @knyg comment on Jan/14/2018, the scope of this extension is to represent the light indicator bar with the intention of, for example, to let user to know which player character is being controlled without testing each controller. Button lightning/backlighting has different purposes, intentions and behaviors of a lightbar and, thus, it's out of the scope of this lightbar gamepad extension proposal.

@marcoscaceres marcoscaceres linked a pull request Oct 29, 2020 that will close this issue
4 tasks
@marcoscaceres marcoscaceres removed the v2 label Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants