Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eventInitDict parameter in GamepadEvent constructor should be optional #216

Open
nondebug opened this issue Oct 10, 2024 · 0 comments · May be fixed by #217
Open

eventInitDict parameter in GamepadEvent constructor should be optional #216

nondebug opened this issue Oct 10, 2024 · 0 comments · May be fixed by #217

Comments

@nondebug
Copy link
Collaborator

nondebug commented Oct 10, 2024

The GamepadEvent constructor is defined with two required parameters:

constructor(DOMString type, GamepadEventInit eventInitDict);

This differs from the signature in implementations which define the second parameter as optional (blink, Gecko, WebKit):

  constructor(DOMString type, optional GamepadEventInit eventInitDict = {}); // blink
  constructor(DOMString type, optional GamepadEventInit eventInitDict = {});  // Gecko
  constructor([AtomString] DOMString type, optional GamepadEventInit eventInitDict);  // WebKit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant