Fix MIME type handling #559
Conversation
| </p> | ||
| </li> | ||
| <li> | ||
| <p> | ||
| Let <var>container</var> be the container type specified by <var>content | ||
| type</var>. | ||
| If <var>mimeType</var> is <code>failure</code> or is unrecognized, |
There was a problem hiding this comment.
What does "unrecognized" mean here?
There was a problem hiding this comment.
I was not the author of that phrase, but I think the distinction between "invalid"/"failure" and "unrecognized" is that you could have a valid MIME type that is not recognized as supported for media playback by the UA, e.g. "image/png".
If this is indeed the intent, I think the term "unrecognized" is not the best we could come up with.
How about If <var>mimeType</var> is <code>failure</code> or is not a supported type for media playback? Is that clear?
There was a problem hiding this comment.
Joey's suggestion is better, but ideally we actually list the MIME types. See also https://mimesniff.spec.whatwg.org/#supported-by-the-user-agent and references.
There was a problem hiding this comment.
I not convinced that an explicit list of supported media types is practical, given the variability in what is supported across the entire ecosystem of media streaming devices.
There was a problem hiding this comment.
There's a related PR for Media Capabilities, see "Check MIME Type Support" in https://github.com/w3c/media-capabilities/pull/222/files. We may be able to reuse this, or maybe even just reference it. But in that PR we reference https://mimesniff.spec.whatwg.org/#supported-by-the-user-agent rather than list MIME types.
There was a problem hiding this comment.
I think "supported by the user agent" plus limiting it to media in some way is reasonable. It will at least give us a central place to work on improving this longer term.
|
@annevk @joeyparrish How does this look? There may be more we could do to be more precise, e.g., "unrecognized", or how to identify the container type from the MIME type, but for now I've tried to reference mimesniff but without introducing other changes. |
| Let <var>container</var> be the container type specified by <var>content | ||
| type</var>. | ||
| If <var>mimeType</var> is <code>failure</code> or is unrecognized, | ||
| continue to the next iteration. |
There was a problem hiding this comment.
At some point you might want to adopt https://infra.spec.whatwg.org/#iteration-continue and other Infra conventions.
There was a problem hiding this comment.
Thanks, let's do this in a separate PR.
I agree, thanks. |
See #511. This PR removes the Valid Media MIME Type definition and references mimesniff for "parse a MIME type".
Further work is needed to address #512.
Preview | Diff