Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec additional Client API features in V2 #1245

Open
6 of 9 tasks
jungkees opened this issue Dec 11, 2017 · 0 comments
Open
6 of 9 tasks

Spec additional Client API features in V2 #1245

jungkees opened this issue Dec 11, 2017 · 0 comments
Milestone
Version 2

Comments

@jungkees
Copy link
Collaborator

jungkees commented Dec 11, 2017 •
edited
Loading

We decided to not expose reserved client that closed #1228 #1215 #1123 #1078 #1035 #1034 #1031 #1030.

For V1,

Remove:

  • Client.reserved.
  • ClientQueryOptions.includeReserved.
  • FetchEvent.reservedClientId.
  • FetchEvent.targetClientId.
  • FetchEventInit.reservedClientId.
  • FetchEventInit.targetClientId.

Do:

  • Clean up the steps of Clients interface methods.

For V2,

Spec:

EDIT: Change the name of FetchEvent.targetClientId (for V2) to FetchEvent.replacesClientId as per #1091 (comment).
@jungkees jungkees added this to the Version 2 milestone Dec 11, 2017
@jungkees jungkees mentioned this issue Dec 11, 2017
Closed
@jungkees jungkees changed the title Spec FetchEvent.resultingClientId/targetClientId Spec additional Client API features in V2 Dec 11, 2017
This was referenced Dec 11, 2017
Closed
Closed
jungkees added a commit that referenced this issue Jan 12, 2018
@jungkees
Clean up Client API to not expose reserved clients
5ab28e8 
To reflect the decision to not expose reserved clients
(#1216) and to spec
.resultingClientId and .targetClientId in Nightly only, this:

* Removes
 - Client.reserved and its associated reserved state (V1, Nightly)
 - ClientQueryOptions.includeReserved (V1, Nightly)
 - FetchEvent.reservedClientId (V1)
 - FetchEvent.targetClientId (V1)
 - FetchEventInit.reservedClientId (V1)
 - FetchEventInit.targetClientId (V1)

* Changes
 - FetchEvent.reservedClientId to FetchEvent.resultingClientId (Nightly)
 - FetchEventInit.reservedClientId to FetchEventInit.resultingClientId
   (Nightly)
 - Handle Fetch to set FetchEvent.clientId for a navigation request to
   the empty string (V1)

* Corrects
 - matchedClients with clientObjects in Clients.matchAll() (V1, Nightly)

Related issue: #1245.

This also cleans up sort condition steps in Clients.matchAll() that
fixes #1080 (V1, Nightly)

(Changes for the Clients interface's methods will be addressed as
separate PRs.)
@jungkees jungkees mentioned this issue Jan 12, 2018
Merged
jungkees added a commit that referenced this issue Jan 13, 2018
@jungkees
Clean up Client API to not expose reserved clients (#1259)
07e9487 
To reflect the decision to not expose reserved clients
(#1216) and to spec
.resultingClientId and .targetClientId in Nightly only, this:

* Removes
 - Client.reserved and its associated reserved state (V1, Nightly)
 - ClientQueryOptions.includeReserved (V1, Nightly)
 - FetchEvent.reservedClientId (V1)
 - FetchEvent.targetClientId (V1)
 - FetchEventInit.reservedClientId (V1)
 - FetchEventInit.targetClientId (V1)

* Changes
 - FetchEvent.reservedClientId to FetchEvent.resultingClientId (Nightly)
 - FetchEventInit.reservedClientId to FetchEventInit.resultingClientId
   (Nightly)
 - Handle Fetch to set FetchEvent.clientId for a navigation request to
   the empty string (V1)

* Corrects
 - matchedClients with clientObjects in Clients.matchAll() (V1, Nightly)

Related issue: #1245.

This also cleans up sort condition steps in Clients.matchAll() that
fixes #1080 (V1, Nightly)

(Changes for the Clients interface's methods will be addressed as
separate PRs.)
jungkees added a commit that referenced this issue Jul 1, 2018
@jungkees
Clean up Clients interface methods
30cb8f1 
As a follow-up of the decision to not expose the reserved client, this change
added a filter exclude discarded client. This change also removes the
unnecessary branch that checks whether the environment's creation URL is
trustworthy as now we're dealing with only the clients that are execution ready.
(i.e. the clients must be an environment settings object at least.)

Related issue: #1245.
@jungkees jungkees mentioned this issue Jul 1, 2018
Merged
jungkees added a commit that referenced this issue Jul 1, 2018
@jungkees
Change name from targetClientId to replacesClientId
b6bb29b 
We had decided (and I forgot) to change the name of FetchEvent.targetClientId to
.replacesClientId to clarify the meaning that this client is a to be replaced
client: #1091 (comment).

Related issue: #1245.
@jungkees jungkees mentioned this issue Jul 1, 2018
Merged
jungkees added a commit to jungkees/fetch that referenced this issue Jul 1, 2018
@jungkees
Change name from target client id to replaces client id
bc2ba08 
We had decided to change the name of FetchEvent.targetClientId to
.replacesClientId to clarify the meaning that this client is a to be replaced
client: w3c/ServiceWorker#1091 (comment).
Accordingly, this changes the name of the request's target client id item to
replaces client id.

Related issue: w3c/ServiceWorker#1245.

SW PR: w3c/ServiceWorker#1333.
@jungkees jungkees mentioned this issue Jul 1, 2018
Merged
jungkees added a commit to jungkees/html that referenced this issue Jul 1, 2018
@jungkees
Change name from target client id to replaces client id
b250bc0 
We had decided to change the name of FetchEvent.targetClientId to
.replacesClientId to clarify the meaning that this client is a to be replaced
client: w3c/ServiceWorker#1091 (comment).
Accordingly, this changes the reference to the request's target client id to
request's replaces client id.

Related issue: w3c/ServiceWorker#1245.

SW PR: w3c/ServiceWorker#1333.
Fetch PR: whatwg/fetch#774.
@jungkees jungkees mentioned this issue Jul 1, 2018
Merged
annevk pushed a commit to whatwg/fetch that referenced this issue Aug 24, 2018
@jungkees @annevk
Rename target client id to replaces client id
4321ab6 
We had decided to change the name of FetchEvent's targetClientId to replacesClientId to clarify the meaning that this client is a to be replaced client: w3c/ServiceWorker#1091 (comment). Accordingly, this changes the name of request's target client id to replaces client id.

See also: 

* w3c/ServiceWorker#1245
* w3c/ServiceWorker#1333
* whatwg/html#3788
annevk pushed a commit to whatwg/html that referenced this issue Aug 24, 2018
@jungkees @annevk
Rename target client id to replaces client id
951f9b0 
We had decided to change the name of FetchEvent's targetClientId to replacesClientId to clarify the meaning that this client is a to be replaced client: w3c/ServiceWorker#1091 (comment). Accordingly, this changes the reference to the request's target client id to request's replaces client id.

See also:

* w3c/ServiceWorker#1245
* w3c/ServiceWorker#1333
* whatwg/fetch#774
jungkees added a commit that referenced this issue Aug 26, 2018
@jungkees
Change name from targetClientId to replacesClientId (#1333)
d2391d4 
We had decided (and I forgot) to change the name of FetchEvent.targetClientId to
.replacesClientId to clarify the meaning that this client is a to-be-replaced
client: #1091 (comment).

Fetch PR: whatwg/fetch#774.
HTML PR: whatwg/html#3788.

Related issue: #1245.
@mfalken mfalken mentioned this issue Oct 1, 2018
Closed
3 tasks
jungkees added a commit that referenced this issue Oct 19, 2018
@jungkees
Clean up Clients interface methods (#1332)
bbe67e1 
As a follow-up of the decision to not expose the reserved client, this change
added a filter exclude discarded client. This change also removes the
unnecessary branch that checks whether the environment's creation URL is
trustworthy as now we're dealing with only the clients that are execution ready.
(i.e. the clients must be an environment settings object at least.)

Related issue: #1245.
mustaqahmed pushed a commit to mustaqahmed/html that referenced this issue Feb 15, 2019
@jungkees @mustaqahmed
Rename target client id to replaces client id
281e060 
We had decided to change the name of FetchEvent's targetClientId to replacesClientId to clarify the meaning that this client is a to be replaced client: w3c/ServiceWorker#1091 (comment). Accordingly, this changes the reference to the request's target client id to request's replaces client id.

See also:

* w3c/ServiceWorker#1245
* w3c/ServiceWorker#1333
* whatwg/fetch#774
mustaqahmed pushed a commit to mustaqahmed/html that referenced this issue Feb 15, 2019
@jungkees @mustaqahmed
Rename target client id to replaces client id
9fb7d73 
We had decided to change the name of FetchEvent's targetClientId to replacesClientId to clarify the meaning that this client is a to be replaced client: w3c/ServiceWorker#1091 (comment). Accordingly, this changes the reference to the request's target client id to request's replaces client id.

See also:

* w3c/ServiceWorker#1245
* w3c/ServiceWorker#1333
* whatwg/fetch#774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 2
Development

No branches or pull requests
1 participant
@jungkees