Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providers list constraint violations should not result in a NetworkError #628

Open
timcappalli opened this issue Aug 2, 2024 · 1 comment
Assignees

Comments

@timcappalli
Copy link

In step 2 of https://fedidcg.github.io/FedCM/#browser-api-rp-sign-in, it reads:

If the size of options["identity"]["providers"] is not equal to 1, queue a global task on the DOM manipulation task source given globalObject to throw a new "NetworkError" DOMException

NetworkError doesn't seem appropriate here. I think it should be a TypeError

@npm1
Copy link
Collaborator

npm1 commented Aug 6, 2024

Yea we have usually used NetworkError for most errors since a lot of them should not be distinguishable from each other. This one in particular would be fine to set as TypeError since it is a 'coding error'. Ideally we'd remove this restriction altogether soon, once we have multi IDP support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants