From 5751d6c88588989280abf3ea98f01cabf0d852a9 Mon Sep 17 00:00:00 2001 From: Christian Biesinger Date: Tue, 29 Oct 2024 12:00:06 -0400 Subject: [PATCH] Address comments from TallTed --- spec/index.bs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/spec/index.bs b/spec/index.bs index 74470793..2839d8e9 100644 --- a/spec/index.bs +++ b/spec/index.bs @@ -1212,14 +1212,14 @@ To fetch an identity assertion given a {{USVString}} 1. ("account_id", |accountId|) 1. ("is_auto_selected", |isAutoSelected|) 1. If |fields| is not empty: - 1. Let |serializedFields| be the entries of |fields| concatenated with a "," + 1. Let |serializedFields| be the entries of |fields| concatenated with a comma ("`,`") between elements. 1. Append ("fields", |serializedFields|) to |list|. 1. If |disclosureShownFor| is not empty: 1. Let |serializedDisclosure| be the entries of |disclosureShownFor| concatenated - with a "," between elements. + with a comma ("`,`") between elements. 1. Append ("disclosure_shown_for", |serializedDisclosure|) to |list|. - 1. If |disclosureShownFor| contains all of "name", "email" and "picture", append + 1. If |disclosureShownFor| contains all of "name", "email", and "picture", append ("disclosure_text_shown", true) to |list|. 1. If |provider|'s {{IdentityProviderRequestOptions/params}} is not empty: 1. Let |json| be the result of [=serializing a JavaScript value to a JSON string=] @@ -1311,7 +1311,7 @@ an {{IdentityProviderAPIConfig}} |config|, an {{IdentityProviderRequestOptions}} {{IdentityProviderBranding}} to inform the style choices of its UI. Additionally: 1. If |provider|.{{IdentityProviderRequestOptions/fields}} is not [=list/empty=]: 1. If |metadata| is not failure, |metadata|["{{IdentityProviderClientMetadata/privacy_policy_url}}"] - is defined and the |provider|'s {{IdentityProviderConfig/clientId}} is not in the list of + is defined, and the |provider|'s {{IdentityProviderConfig/clientId}} is not in the list of |account|["{{IdentityProviderAccount/approved_clients}}"], then the user agent MUST display the |metadata|["{{IdentityProviderClientMetadata/privacy_policy_url}}"] link. 1. If |metadata| is not failure, |metadata|["{{IdentityProviderClientMetadata/terms_of_service_url}}"] @@ -1319,7 +1319,7 @@ an {{IdentityProviderAPIConfig}} |config|, an {{IdentityProviderRequestOptions}} |account|["{{IdentityProviderAccount/approved_clients}}"], then the user agent MUST display the |metadata|["{{IdentityProviderClientMetadata/terms_of_service_url}}"] link. 1. The user agent MUST prompt the user for permission to share the data in |fields|, - interpreting the strings as follows (this is the list of recognized fields): + interpreting the strings in the list of recognized fields as follows: : `"name"` :: The user's name as given in {{IdentityProviderAccount}}.{{IdentityProviderAccount/name}}. : `"email"`