From 151c050a6d9281ebae981c44dbff13799dab7036 Mon Sep 17 00:00:00 2001
From: Ilmari Karonen <nospam@vyznev.net>
Date: Sun, 25 Oct 2015 00:48:26 +0300
Subject: [PATCH] release v1.39.8 as v1.40.0

---
 CHANGELOG.md | 27 ++++++++++++++-
 README.md    | 11 +++++--
 SOUP.meta.js |  2 +-
 SOUP.user.js | 93 ++++++++++++++++++++++++++++++++++++++++++++++++++--
 4 files changed, 127 insertions(+), 6 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8e244a0..b5f80f3 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,31 @@ This is a list of new fixes and other changes made to SOUP during its continued
 
 SOUP version numbering generally follows the _major.minor.patch_ scheme.  Odd minor versions (1.1.x, 1.3.x, 1.5.x, etc.) are reserved for unstable development versions ("devel" branch on [GitHub][github]), while even ones denote stable releases ("master" branch on [GitHub][github]).  The change log below thus only includes even version numbers, as changes between development versions are too numerous to list.
 
+
+1.40 (25 Oct 2015)
+====
+
+Just a bunch of new fixes, nothing too special this time.  The [mso308513](http://meta.stackoverflow.com/q/308513) issue has already been marked "status-completed" by SE, but it hasn't been deployed quite yet and having the style twice should do no harm, so I'm leaving it in for this release.
+
+**New fixes in 1.40.0:**
+
+* [rpg5812: Post as a guest: CSS bug](http://meta.rpg.stackexchange.com/q/5812) (CSS)
+* [mso308513: Styling issue on upvoted comments by diamond moderators](http://meta.stackoverflow.com/q/308513) (CSS)
+* [mse139175: When starring a message from the star board, it's not reflected in the main chat window](http://meta.stackexchange.com/q/139175) (chat)
+* [mse153528: Don't ask for a comment when downvoting, if the user just voted on a comment](http://meta.stackexchange.com/q/153528)
+* [mse259325: Answer flashes orange when I click the “edit (1)” link to review a suggested edit](http://meta.stackexchange.com/q/259325)
+* [mso306552: Votes cast has upvote-like symbol and is confusing](http://meta.stackoverflow.com/q/306552) (credit: AgeDeO and misterManSam)
+* [mso308672: Alerts no longer work in StackOverflow snippets in Chrome 46+](http://meta.stackoverflow.com/q/308672)
+
+**Removed fixes:**
+
+* [mso283939: Flag for diamond moderator textarea breaks out of the dialog](http://meta.stackoverflow.com/q/283939)
+
+**Other changes:**
+
+* SOUP no longer injects its code into `<iframe>`s.  While there have been no reported bugs caused by this, it's still useless and unintentional behavior.
+
+
 1.38 (3 Oct 2015)
 ====
 
@@ -40,7 +65,7 @@ Removed the following fixes, as they're no longer needed:
 * [mse266747: Amazing! All sites have blogs!](http://meta.stackexchange.com/q/266747)
 * [mse266779: Upload image not working after providing wrong URL](http://meta.stackexchange.com/q/266779)
 * [mso297171: Comment warning appears on next comment](http://meta.stackoverflow.com/q/297171)
-* [mso283939: Flag for diamond moderator textarea breaks out of the dialog](http://meta.stackoverflow.com/q/283939) (applied globally)
+* [mso283939: Flag for diamond moderator textarea breaks out of the dialog](http://meta.stackoverflow.com/q/283939)
 
 
 1.36 (13 Sep 2015)
diff --git a/README.md b/README.md
index 0953463..c6f814d 100644
--- a/README.md
+++ b/README.md
@@ -1,5 +1,5 @@
 <!-- thumbnail: http://i.stack.imgur.com/8EphO.png -->
-<!-- version: 1.38.2 -->
+<!-- version: 1.40.0 -->
 
 ![](http://i.stack.imgur.com/IzzhJ.png "SOUP logo")
 
@@ -29,7 +29,7 @@ SOUP can also be used on other browsers with compatible user script support, suc
 Included fixes
 --------------
 
-SOUP v1.38.2 includes fixes or workarounds for the following issues.
+SOUP v1.40.0 includes fixes or workarounds for the following issues.
 
 The fixes highlighted in **boldface** include particularly major interface improvements or fix particularly severe or widespread issues.  The choice of which fixes to highlight is unavoidably somewhat subjective, but in my personal opinion, these are the fixes you should actually install SOUP for &mdash; the rest are just icing on the cake.
 
@@ -63,6 +63,7 @@ These are pure CSS fixes.  They will be applied even if JavaScript is disabled o
 * [mso297678: Comment anchor links get “visited” highlighting](http://meta.stackoverflow.com/q/297678)
 * [mse242944: Long display name with no spaces breaks design of review history pages](http://meta.stackexchange.com/q/242944)
 * [mse266258: Left side markdown diff outside of its area](http://meta.stackexchange.com/q/266258)
+* [mso308513: Styling issue on upvoted comments by diamond moderators](http://meta.stackoverflow.com/q/308513)
 
 ### Site-specific CSS fixes
 
@@ -83,6 +84,7 @@ These pure CSS fixes are for issues specific to certain sites on the Stack Excha
 * [mse244587: “Top Network Users” should contain themselves!](http://meta.stackexchange.com/q/244587)
 * [rpg3554: Skin does not handle read-only mode well](http://meta.rpg.stackexchange.com/q/3554)
 * [mso306325: The yellow star in the sprites.svg image looks “unfinished”](http://meta.stackoverflow.com/q/306325)
+* [rpg5812: Post as a guest: CSS bug](http://meta.rpg.stackexchange.com/q/5812) (enabled globally)
 
 ### Chat-only fixes
 
@@ -93,6 +95,7 @@ These fixes apply only to the [Stack Exchange Network chat](http://chat.stackexc
 * [mse222509: Getting Red Line under tags](http://meta.stackexchange.com/q/222509)
 * [mse134268: U+0008 inserted into chat @-pings](http://meta.stackexchange.com/q/134268)
 * [mse224233: Problem in css style loading in Search Bar after refresh page when using FF](http://meta.stackexchange.com/q/224233)
+* [mse139175: When starring a message from the star board, it's not reflected in the main chat window](http://meta.stackexchange.com/q/139175)
 
 ### General fixes
 
@@ -125,6 +128,10 @@ These fixes apply only to the [Stack Exchange Network chat](http://chat.stackexc
 * [mse266523: Uploading an image from the web can leave paste broken in editor](http://meta.stackexchange.com/q/266523)
 * [mse264307: Down arrow key won't work after using the Hyperlink button](http://meta.stackexchange.com/q/264307)
 * [mse170970: Occasionally, the Unicode character sequence U+200C U+200B (ZWNJ ZWSP) is inserted into comments](http://meta.stackexchange.com/q/170970)
+* [mse153528: Don't ask for a comment when downvoting, if the user just voted on a comment](http://meta.stackexchange.com/q/153528)
+* [mse259325: Answer flashes orange when I click the “edit (1)” link to review a suggested edit](http://meta.stackexchange.com/q/259325)
+* [mso306552: Votes cast has upvote-like symbol and is confusing](http://meta.stackoverflow.com/q/306552)
+* [mso308672: Alerts no longer work in StackOverflow snippets in Chrome 46+](http://meta.stackoverflow.com/q/308672)
 
 ### Site-specific fixes
 
diff --git a/SOUP.meta.js b/SOUP.meta.js
index f3786f0..bfc4f01 100644
--- a/SOUP.meta.js
+++ b/SOUP.meta.js
@@ -3,7 +3,7 @@
 // @namespace   https://github.com/vyznev/
 // @description Miscellaneous client-side fixes for bugs on Stack Exchange sites
 // @author      Ilmari Karonen
-// @version     1.38.2
+// @version     1.40.0
 // @copyright   2014-2015, Ilmari Karonen (http://stackapps.com/users/10283/ilmari-karonen)
 // @license     ISC; http://opensource.org/licenses/ISC
 // @match       *://*.stackexchange.com/*
diff --git a/SOUP.user.js b/SOUP.user.js
index 6294f27..e12275d 100644
--- a/SOUP.user.js
+++ b/SOUP.user.js
@@ -3,7 +3,7 @@
 // @namespace   https://github.com/vyznev/
 // @description Miscellaneous client-side fixes for bugs on Stack Exchange sites
 // @author      Ilmari Karonen
-// @version     1.38.2
+// @version     1.40.0
 // @copyright   2014-2015, Ilmari Karonen (http://stackapps.com/users/10283/ilmari-karonen)
 // @license     ISC; http://opensource.org/licenses/ISC
 // @match       *://*.stackexchange.com/*
@@ -51,6 +51,9 @@
 var include_re = /(^|\.)((stack(exchange|overflow|apps)|superuser|serverfault|askubuntu)\.com|mathoverflow\.net)$/;
 if ( ! include_re.test( location.hostname ) ) return;
 
+// we don't want to mess with iframes; SE does frame-busting anyway, so any real SE pages should be in top-level frames
+try { if ( window.self !== window.top ) return } catch (e) { return }
+
 var fixes = {};
 
 //
@@ -238,6 +241,11 @@ fixes.mse266258 = {
 	url:	"http://meta.stackexchange.com/q/266258",
 	css:	".full-diff .diff-delete:after, .full-diff .diff-add:after { content: ''; font-size: 0px }"
 };
+fixes.mso308513 = {
+	title:	"Styling issue on upvoted comments by diamond moderators",
+	url:	"http://meta.stackoverflow.com/q/308513",
+	css:	".mod-flair { line-height: 1 }"
+};
 
 
 // site-specific CSS fixes:
@@ -378,6 +386,13 @@ fixes.mso306325 = {
 		'body .star-off { background-position: 0px 0px }' +
 		'body .star-on { background-position: -40px 0px }'
 };
+fixes.rpg5812 = {
+	title:	"Post as a guest: CSS bug",
+	url:	"http://meta.rpg.stackexchange.com/q/5812",
+	credit:	"polkovnikov.ph",
+	css:	".new-login-form .new-login-right input, .new-login-form .new-login-right table  { width: 100%; box-sizing: border-box }"
+};
+
 
 
 //
@@ -435,6 +450,26 @@ fixes.mse224233 = {
 		} ).filter('.watermark').val('').removeClass('watermark');
 	}
 };
+fixes.mse139175 = {
+	title:	"When starring a message from the star board, it's not reflected in the main chat window",
+	url:	"http://meta.stackexchange.com/q/139175",
+	sites:	/^chat\./,
+	script:	function () {
+		var syncMsgStar = function () {
+			var $this = $(this);
+			var starred = $this.hasClass('user-star');
+			var id = $this.closest('li').attr('id').match(/\d+/)[0];
+			var msgStar = $('#message-' + id + ' .stars');
+
+			if ( starred ) msgStar.addClass('user-star');
+			else msgStar.removeClass('user-star');
+		};
+		var selector = '#starred-posts .sidebar-vote';
+		// XXX: this needs to run after the SE click handler; looks like it does
+		$(document).on( 'click', selector, syncMsgStar );
+		SOUP.hookAjax( /^\/chats\/stars\b/, function () { $(selector).each(syncMsgStar) } );
+	}
+};
 
 
 //
@@ -1061,7 +1096,61 @@ fixes.mse170970 = {
 		}, 'mse170970', null, ['load', 'post', 'comments'] );
 	}
 };
-
+fixes.mse153528 = {
+	title:	"Don't ask for a comment when downvoting, if the user just voted on a comment",
+	url:	"http://meta.stackexchange.com/q/153528",
+	script:	function () {
+		// TODO: add localized message variants?
+		var re = /^Please consider adding a comment if you think this post can be improved\.$/;
+		var oldShowInfoMsg = StackExchange.helpers.showInfoMessage;
+		StackExchange.helpers.showInfoMessage = function ( elem, message, options ) {
+			if ( re.test(message) ) {
+				var post = $(elem).closest('.question, .answer');
+				if ( post.has('.comment-up-on').length ) return null;
+			}
+			return oldShowInfoMsg.apply( this, arguments );
+		};
+	}
+};
+fixes.mse259325 = {
+	title:	"Answer flashes orange when I click the “edit (1)” link to review a suggested edit",
+	url:	"http://meta.stackexchange.com/q/259325",
+	script:	function () {
+		// the initial hashchange event has already fired, so we can safely ignore any later
+		// events that don't correspond to an actual change in the hash
+		var oldHash = location.hash;
+		( $._data(window, 'events').hashchange || [] ).forEach( function (h) {
+			if ( ! h.namespace || h.namespace !== 'highlightDestination' ) return;
+			var oldHandler = h.handler;
+			h.handler = function (e) {
+				if ( oldHash === location.hash ) return;
+				oldHash = location.hash;
+				return oldHandler.apply( this, arguments );
+			};
+		} );
+	}
+};
+fixes.mso306552 = {
+	title:	"Votes cast has upvote-like symbol and is confusing",
+	url:	"http://meta.stackoverflow.com/q/306552",
+	credit:	"AgeDeO and misterManSam",
+	script:	function () {
+		if ( ! /^\/users\/\d+/.test( location.pathname ) ) return;
+		$('body.user-page .impact-card .icon-vote-cast').removeClass('icon-vote-cast').addClass('icon-up-down soup-mso306552-tweak');
+	},
+	css:	"body.user-page .impact-card .icon-up-down.soup-mso306552-tweak { margin: 0 4px 0 -3px }"
+};
+fixes.mso308672 = {
+	title:	"Alerts no longer work in StackOverflow snippets in Chrome 46+",
+	url:	"http://meta.stackoverflow.com/q/308672",
+	script:	function () {
+		$(document).on( 'submit', 'form[action="//stacksnippets.net/js"]', function () {
+			if ( ! /^[\-0-9A-Za-z]+$/.test( this.target ) ) return;  // safety check
+			var iframe = $( 'iframe[name="' + this.target + '"][sandbox=allow-scripts]' );
+			iframe.attr( 'sandbox', 'allow-scripts allow-modals' );
+		} );
+	}
+};
 
 
 //