Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exit instruction in runtime code #4317

Open
charles-cooper opened this issue Oct 20, 2024 · 0 comments · May be fixed by #4318
Open

exit instruction in runtime code #4317

charles-cooper opened this issue Oct 20, 2024 · 0 comments · May be fixed by #4318
Assignees
@charles-cooper @harkal @HodanPlodky @sandbubbles
Labels
bug - venom bug in experimental venom pipeline Refactor Issues related to refactoring the codebase

Comments

@charles-cooper
Copy link
Member

charles-cooper commented Oct 20, 2024 •
edited
Loading

the following code emits an exit instruction in the runtime code

totalShares: public(uint256)

# Set up the company.
@deploy
def __init__(_total_shares: uint256):
    pass

running vyper --experimental-codegen -f bb_runtime gives:

fallback:  IN=[__main_entry, 47_if_exit] OUT=[] => {}
    revert 0, 0
    exit

Originally posted by @sandbubbles in #4314 (comment)

this isn't a big deal since the exit gets optimized out, but we should remove it as a matter of well-formedness.
@charles-cooper charles-cooper added Refactor Issues related to refactoring the codebase bug - venom bug in experimental venom pipeline labels Oct 20, 2024
@charles-cooper charles-cooper linked a pull request Oct 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charles-cooper charles-cooper

@harkal harkal

@HodanPlodky HodanPlodky

@sandbubbles sandbubbles

Labels
bug - venom bug in experimental venom pipeline Refactor Issues related to refactoring the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor[venom]: update translator for deploy instruction charles-cooper/vyper
4 participants
@charles-cooper @harkal @HodanPlodky @sandbubbles