eval/injection reverts fail to report their error message.

[AlbertoCentonze]

When eval/injection calls an internal function that reverts with some specific error message. The error message is not reported correctly making it very hard to debug the source of the issue.

[charles-cooper]

The error message is not reported correctly

hmm, can you explain?

[AlbertoCentonze]

Given a function bar() in a contract A whose source is:

@internal
@view
def bar(whatever: bool) -> uint256:
    assert whatever, "the value is false"
    return 42

Let's say we inject a function foo()

import textwrap

source = textwrap.dedent("""
@view
@external
def foo() -> uint256:
    return self.bar(False)
""")

A.inject_function(source)

If we attempt to call foo boa will ofc revert but will not be able to report that the error is "the value is false".

If this is a technical limitation, there could be a better error specifying that some assertion happened inside the injected function and it couldn't be reported.

[charles-cooper]

ok gotcha. i think we should handle this in theory, the fact that we don't is a bug. see

titanoboa/boa/contracts/vyper/vyper_contract.py

Line 1157 in a52c79c

self._source_map = source_map