Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boa.env.fork is allowed on NetworkEnv but will broadcast transactions #321

Open
PatrickAlphaC opened this issue Oct 1, 2024 · 1 comment

Comments

@PatrickAlphaC
Copy link
Contributor

I can run:

boa.env.fork(URL, deprecated=False)

And then, if I deploy a contract or try to send a TX, if I have an account added, it will broadcast the transaction instead of running it on the pyevm.

This should be disabled, you should not be able to send transactions on a real network when the API makes you think you are on a forked network.

@charles-cooper charles-cooper changed the title boa.env.fork is allowed but will broadcast transactions boa.env.fork is allowed on NetowrkEnv but will broadcast transactions Oct 1, 2024
@charles-cooper charles-cooper changed the title boa.env.fork is allowed on NetowrkEnv but will broadcast transactions boa.env.fork is allowed on NetworkEnv but will broadcast transactions Oct 1, 2024
@charles-cooper
Copy link
Member

yea, it probably makes sense to raise an exception here for NetworkEnv.

also it looks like you are running with deprecated=False, which tells titanoboa you know what you are doing :). normally at least a warning would be issued.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants