Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cc_vyos: T5862: Fixed network configuration #69

Merged
merged 1 commit into from
Dec 29, 2023
Merged

cc_vyos: T5862: Fixed network configuration #69

merged 1 commit into from
Dec 29, 2023

Conversation

zdc
Copy link
Contributor

@zdc zdc commented Dec 28, 2023

  • added extra check for maximum supported MTU to avoid exceeding it during configuration
  • remove udev rules created by cloud-init after initialization
  • fixed logic for config file selection

@zdc
cc_vyos: T5862: Fixed network configuration
ceea266 
- added extra check for maximum supported MTU to avoid exceeding it during
configuration
- remove udev rules created by cloud-init after initialization
- fixed logic for config file selection
sever-sever
sever-sever approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@sever-sever sever-sever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The question is only for old format instead of f-strings
The other looks good.

@zdc zdc merged commit 9f8bdf9 into vyos:equuleus Dec 29, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-po c-po c-po approved these changes

@sever-sever sever-sever sever-sever approved these changes

@dmbaturin dmbaturin Awaiting requested review from dmbaturin

@jestabro jestabro Awaiting requested review from jestabro

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zdc @sever-sever @c-po