configdep: T6559: fix regression in dependent script error under configd

[jestabro]

Change Summary

A regression in the redundant dependency removal when running under configd (T5660) can cause a crash of the config daemon leaving the commit session uncompleted. This occurs when the last element of the priority queue succeeds, but a resulting dependency fails. Taras pointed this out in the case of a particularly crafted config file, but a simple reproducer is as follows:

set firewall group address-group AG address '192.168.137.5'
set nat source rule 10 source group address-group 'AG'
set nat source rule 10 translation address 'masquerade'
set nat source rule 10 outbound-interface name 'eth1'
commit
delete firewall
commit

The reproducer is added as a smoketest to check graceful exit and reporting of error.
The PR drops the asynchronous calling of dependent scripts, as a fix there would still lack the ability to map the error to the originating element of the priority queue. Secondly, it simplifies the management of the dependency list when running with or without configd.

Configtest and smoketests pass in current (note that smoketests now default to running with configd in current); configtest and configd smoketests pass in sagitta, and sagitta 'make test' (no configd) shows only the errors recently seen in CI.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
• Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Smoketest result

vyos@vyos:~$ /usr/libexec/vyos/tests/smoke/cli/test_config_dependency.py 
test_configdep_error (__main__.TestConfigDep.test_configdep_error) ... 
firewall: ConfigError('dependent nat: Invalid address-group "AG" on nat rule')

ok

----------------------------------------------------------------------
Ran 1 test in 5.997s

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• I have run the components SMOKETESTS if applicable
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly

[github-actions]

👍
No issues in PR Title / Commit Title

[github-actions]

👍
No issues in unused-imports

[github-actions]

CI integration ❌ failed!

Details

CI logs

• CLI Smoketests ❌ failed
• Config tests 👍 passed
• RAID1 tests 👍 passed

[jestabro]

@Mergifyio backport circinus

[mergify]

backport circinus

✅ Backports have been created

• #3822 configdep: T6559: fix regression in dependent script error under configd (backport #3813) has been created for branch circinus

[jestabro]

@Mergifyio backport sagitta

[mergify]

backport sagitta

✅ Backports have been created

• #3824 configdep: T6559: fix regression in dependent script error under configd (backport #3813) has been created for branch sagitta