Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smoketest: T6539: remove explicit test for non existing global log entry #3790

Merged
merged 1 commit into from
Jul 5, 2024
Merged

smoketest: T6539: remove explicit test for non existing global log entry #3790

merged 1 commit into from
Jul 5, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Jul 5, 2024 •
edited
Loading

Change Summary

Commit dd5908e ("T6539: add logging options to load-balancer reverse-proxy") added CLI commands to add custom log entries for frontend and backend servers as well as a global log directive.

Remove explicit test code for no longer always present "global log" directive.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Smoketest result

[email protected]:~$ /usr/libexec/vyos/tests/smoke/cli/test_load-balancing_reverse-proxy.py
test_01_lb_reverse_proxy_domain (__main__.TestLoadBalancingReverseProxy.test_01_lb_reverse_proxy_domain) ... ok
test_02_lb_reverse_proxy_cert_not_exists (__main__.TestLoadBalancingReverseProxy.test_02_lb_reverse_proxy_cert_not_exists) ... ok
test_03_lb_reverse_proxy_ca_not_exists (__main__.TestLoadBalancingReverseProxy.test_03_lb_reverse_proxy_ca_not_exists) ... ok
test_04_lb_reverse_proxy_backend_ssl_no_verify (__main__.TestLoadBalancingReverseProxy.test_04_lb_reverse_proxy_backend_ssl_no_verify) ... ok
test_05_lb_reverse_proxy_backend_http_check (__main__.TestLoadBalancingReverseProxy.test_05_lb_reverse_proxy_backend_http_check) ... ok
test_06_lb_reverse_proxy_tcp_mode (__main__.TestLoadBalancingReverseProxy.test_06_lb_reverse_proxy_tcp_mode) ... ok
test_07_lb_reverse_proxy_http_response_headers (__main__.TestLoadBalancingReverseProxy.test_07_lb_reverse_proxy_http_response_headers) ... ok
test_08_lb_reverse_proxy_tcp_health_checks (__main__.TestLoadBalancingReverseProxy.test_08_lb_reverse_proxy_tcp_health_checks) ... ok
test_09_lb_reverse_proxy_logging (__main__.TestLoadBalancingReverseProxy.test_09_lb_reverse_proxy_logging) ... ok

----------------------------------------------------------------------
Ran 9 tests in 62.535s

OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po
smoketest: T6539: remove explicit test for non existing global log entry
b71481f 
Commit dd5908e ("T6539: add logging options to load-balancer reverse-proxy")
added CLI commands to add custom log entries for frontend and backend servers
as well as a global log directive.

Remove explicit test code for no longer always present "global log" directive.
@c-po c-po requested a review from a team as a code owner July 5, 2024 06:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024 •
edited
Loading

👍
No issues in PR Title / Commit Title

@c-po c-po enabled auto-merge July 5, 2024 06:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

CI integration ❌ failed!

Details

CI logs

  • ❌ failed CLI Smoketests returned: 1
  • 👍 passed Config tests returned: 0
  • 👍 passed RAID1 tests returned: 0

@c-po c-po merged commit f5f8373 into vyos:current Jul 5, 2024
12 of 14 checks passed
@c-po c-po deleted the reverse-proxy-log-fix branch July 5, 2024 18:46
@c-po c-po mentioned this pull request Jul 5, 2024
Merged
12 tasks
@c-po
Copy link
Member Author

c-po commented Aug 7, 2024

@Mergifyio backport sagitta circinus

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 7, 2024 •
edited
Loading

backport sagitta circinus

✅ Backports have been created

This was referenced Aug 7, 2024
Merged
Merged
c-po added a commit that referenced this pull request Aug 7, 2024
@c-po
Merge pull request #3954 from vyos/mergify/bp/circinus/pr-3790
c0ce26f 
smoketest: T6539: remove explicit test for non existing global log entry (backport #3790)
c-po added a commit that referenced this pull request Aug 8, 2024
@c-po
Merge pull request #3953 from vyos/mergify/bp/sagitta/pr-3790
7a4a462 
smoketest: T6539: remove explicit test for non existing global log entry (backport #3790)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sever-sever sever-sever sever-sever approved these changes

@dmbaturin dmbaturin dmbaturin approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev was automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc was automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro was automatically assigned from vyos/reviewers

@nicolas-fort nicolas-fort Awaiting requested review from nicolas-fort nicolas-fort was automatically assigned from vyos/reviewers

Assignees

@c-po c-po

Labels
backport current
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c-po @dmbaturin @sever-sever