-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T6523: Telegraf use nft scripts only if the firewall configured #3748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a firewall is not configured there is no reason to get and execute telegraf firewall custom scripts as there are no nft chain in the firewall nftables configuration
sever-sever
requested review from
dmbaturin,
sarthurdev,
zdc,
jestabro,
c-po and
fett0
July 2, 2024 08:51
👍 |
dmbaturin
approved these changes
Jul 2, 2024
👍 VyOS CLI smoketests finished successfully! |
fett0
approved these changes
Jul 2, 2024
sarthurdev
approved these changes
Jul 2, 2024
c-po
approved these changes
Jul 2, 2024
@Mergifyio backport circinus |
✅ Backports have been created
|
@Mergifyio backport sagitta |
✅ Backports have been created
|
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
If a firewall is not configured, there is no reason to get and execute telegraf firewall custom scripts as there are no nft chain in the firewall nftables configuration
Types of changes
Related Task(s)
Related PR(s)
Component(s) name
telegraf
Proposed changes
How to test
Before the fix, there was unexpected message:
After the fix:
Smoketest result
Checklist: