Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify dist/* file in CI #45

Open
louisinger opened this issue May 21, 2023 · 1 comment
Open

Verify dist/* file in CI #45

louisinger opened this issue May 21, 2023 · 1 comment

Comments

@louisinger
Copy link
Contributor

dist/ contains the compiled secp256k1-zkp lib. Before merging to master, CI should ensure that this file is up to date with the latest version of the git submodule ( = do the npm run compile job and compare file in CI workflow)

what do u think @altafan ?
@altafan
Copy link
Collaborator

altafan commented May 22, 2023

It could be a nice-to-have feature, but I don't think this has super priority at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@altafan @louisinger