Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] vci auth login web does not work with Safari - blocks non-HTTPS even if its localhost #76

Open
1 of 3 tasks
acidjazz opened this issue Jul 15, 2024 · 1 comment · Fixed by #79
Open
1 of 3 tasks
Labels
bug Something isn't working

Comments

@acidjazz
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

safari blocks non-https traffic even if its localhost.

https://stackoverflow.com/questions/46394682/safari-keeps-forcing-https-on-localhost

Expected Behavior

allow non-https from localhost since its not really remote

Steps To Reproduce

No response

Which operating system where you on?

Mac

Anything else?

possible fixes

  • add copy to warn that this does not work (non-breaking)
  • look into shipping the CLI with its own cert/key so that it can serve properly over https ( breaking )
@acidjazz acidjazz added the bug Something isn't working label Jul 15, 2024
@acidjazz acidjazz changed the title [BUG] vci auth login web does not work with Safari - safari blocks non-HTTPS even if its localhost [BUG] vci auth login web does not work with Safari - blocks non-HTTPS even if its localhost Jul 15, 2024
@acidjazz
Copy link
Contributor Author

@acidjazz acidjazz reopened this Jul 15, 2024
@acidjazz acidjazz linked a pull request Jul 23, 2024 that will close this issue
@acidjazz acidjazz reopened this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant