Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permanent tooltips are not reactive #446

Closed
yohannlegrand opened this issue Sep 26, 2019 · 7 comments
Closed

Permanent tooltips are not reactive #446

yohannlegrand opened this issue Sep 26, 2019 · 7 comments
Labels
bug confirmed Issue is accepted as either a bug or a valid enhancement

Comments

@yohannlegrand
Copy link

Description

Tooltips set with 'permanent' option aren't reactive.
In my application, the refresh of my data doesn't update the tooltips when they are set with 'permanent: true'.
For example, I try to update the option object when data.isActive is updated (I use Vuex for reactivity and I loop through my data to show the tooltips)
But Leaflet doesn't update the tooltip.

Versions

  • Leaflet: v1.5.1
  • Vue: v2.6.10
  • Vue2Leaflet: v2.2.1
@DonNicoJs
Copy link
Member

@yohannlegrand Sorry for the very slow reply, I will investigate this

@DonNicoJs DonNicoJs added the bug label Nov 7, 2019
@ivopisarovic
Copy link

Confirming this bug.

@DonNicoJs DonNicoJs added the confirmed Issue is accepted as either a bug or a valid enhancement label Jan 1, 2020
@bkarlson
Copy link

Confirming too: updating marker coordinates from Vue moves marker, but not tooltip. When dragging marker with mouse/tap, everything's fine.

@darivs
Copy link

darivs commented Aug 9, 2021

Are there any news on this topic @DonNicoJs ? It would be very handy if the tooltip options could be updated reactively

@ryanmoore-SM
Copy link

ryanmoore-SM commented Aug 10, 2021

Discovered this today as well. Didn't realize it was because of the permanent option til I found this post.

Edit: I removed the permanent option, but tooltips are not being removed when a v-if condition is false

@kuromoka
Copy link
Contributor

I submitted PR #718

@KoRiGaN KoRiGaN closed this as completed Jul 10, 2024
@KoRiGaN
Copy link
Collaborator

KoRiGaN commented Jul 10, 2024

PR from @kuromoka is now merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed Issue is accepted as either a bug or a valid enhancement
Projects
None yet
Development

No branches or pull requests

8 participants