Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function find_partition() have no is_membership_fixed argument #99

Open
CDPDisk opened this issue Mar 18, 2022 · 2 comments
Open

Function find_partition() have no is_membership_fixed argument #99

CDPDisk opened this issue Mar 18, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@CDPDisk
Copy link

CDPDisk commented Mar 18, 2022

I noticed that in your docs about fixed nodes it says:

This can be done using the is_membership_fixed argument of find_partition(), see 2 for some details.

And a sample program is provided. But after I viewed the code of find_partition(), I found that find_partition() does not support the argument is_membership_fixed. If I were to use it, I'd have to give up find_partition() and customize a new find_partition() myself to use this argument. Although it is easy, I'd like to add the argument to find_partition() in the future version.

@vtraag
Copy link
Owner

vtraag commented Mar 30, 2022

Indeed, find_partition does not support this argument now right away. For more advanced uses, you should construct an Optimiser object and call optimise_partition, for which you can use the argument is_membership_fixed, e.g. for some partition and some list fixed indicating for each node whether its membership is fixed, you can call it like

optimiser = la.Optimiser()
diff = optimiser.optimise_partition(partition, is_membership_fixed=fixed)

Your question is essentially whether is_membership_fixed can also be made available directly through find_partition?

@CDPDisk
Copy link
Author

CDPDisk commented Apr 3, 2022

Yes, I hope is_membership_fixed can also be made available directly through find_partition. So fixing membership can be more easy.

@vtraag vtraag added the enhancement New feature or request label Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants