Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

合并更新申请 #16

Open
ChuckIsReady opened this issue Aug 27, 2014 · 4 comments
Open

合并更新申请 #16

ChuckIsReady opened this issue Aug 27, 2014 · 4 comments

Comments

@ChuckIsReady
Copy link

合并更新申请

标签(空格分隔): 未分类


基于你们的代码,
我增加了覆盖默认首页的代码,
还有增加了
强制记忆账户密码
默认焦点验证码输入框
写完验证码自动登录的功能

不过因为没有你们的密钥,所以不能打包成你们原来的扩展
新的扩展在这里,安装后就可以拿到代码了
(newmain.css里是没有压缩的新首页css文件,不是必要文件):
http://pan.baidu.com/s/1sjuess1
演示图片:
此处输入图片的描述

如果有需要的话,就合并进去吧。

@bcho
Copy link
Member

bcho commented Aug 27, 2014

wow 赞!能提供一下代码么?我好 merge 进去

@bcho
Copy link
Member

bcho commented Aug 27, 2014

hi @ChuckIsReady 我看了下源码,貌似你那个“写完验证码自动登录”的实现有点问题

https://gist.github.com/bcho/f11e804611aae80d85f3#file-gdut-jwgl-helper-js-L457-L464

我这边好像不可以用噢。你可以尝试换一种方法来标记这个 input 里面的值是否 dirty 以及在输入完之后加一点小延时,这样可能会好一点。

btw 如果可以,我建议你直接 fork 一下然后做修改,然后好了发一个 pr 到这里来就好 ~

Thanks 🍻

@bcho
Copy link
Member

bcho commented Aug 27, 2014

cc @linkkingjay @Yannyezixin

@linkkingjay
Copy link
Member

赞~ 麻烦 @bcho@Yannyezixin 帮忙 review 代码。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants